Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5674)

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper_unittest.cc

Issue 579033002: [Clean-up] Remove some dead code for handling Webstore sign-in. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Restore incorrectly deleted code Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/sync/one_click_signin_helper_unittest.cc
diff --git a/chrome/browser/ui/sync/one_click_signin_helper_unittest.cc b/chrome/browser/ui/sync/one_click_signin_helper_unittest.cc
index a69c8a4283f9bbb6e70998daef5ac28582f6dbbe..bf982c3b51aad8302341e93a1ad521ff9aa1f89c 100644
--- a/chrome/browser/ui/sync/one_click_signin_helper_unittest.cc
+++ b/chrome/browser/ui/sync/one_click_signin_helper_unittest.cc
@@ -671,43 +671,6 @@ TEST_F(OneClickSigninHelperIncognitoTest, ShowInfoBarUIThreadIncognito) {
rvh()->GetRoutingID());
}
-// If Chrome signin is triggered from a webstore install, and user chooses to
-// config sync, then Chrome should redirect immediately to sync settings page,
-// and upon successful setup, redirect back to webstore.
-TEST_F(OneClickSigninHelperTest, SigninFromWebstoreWithConfigSyncfirst) {
- SetUpSigninManager(std::string());
- EXPECT_CALL(*signin_manager_, IsAllowedUsername(_))
- .WillRepeatedly(Return(true));
-
- OneClickTestProfileSyncService* sync_service =
- static_cast<OneClickTestProfileSyncService*>(
- ProfileSyncServiceFactory::GetInstance()->SetTestingFactoryAndUse(
- profile(), OneClickTestProfileSyncService::Build));
- sync_service->set_sync_initialized(true);
-
- content::WebContents* contents = web_contents();
-
- OneClickSigninHelper::CreateForWebContentsWithPasswordManager(contents, NULL);
- OneClickSigninHelper* helper =
- OneClickSigninHelper::FromWebContents(contents);
- helper->SetDoNotClearPendingEmailForTesting();
- helper->set_do_not_start_sync_for_testing();
-
- GURL continueUrl("https://chrome.google.com/webstore?source=5");
- OneClickSigninHelper::ShowInfoBarUIThread(
- "session_index", "user@gmail.com",
- OneClickSigninHelper::AUTO_ACCEPT_EXPLICIT,
- signin::SOURCE_WEBSTORE_INSTALL,
- continueUrl, process()->GetID(), rvh()->GetRoutingID());
-
- SubmitGAIAPassword(helper);
-
- NavigateAndCommit(GURL("https://chrome.google.com/webstore?source=3"));
- helper->DidStopLoading(rvh());
- sync_service->NotifyObservers();
- EXPECT_EQ(GURL(continueUrl), contents->GetVisibleURL());
-}
-
// Checks that the state of OneClickSigninHelper is cleaned when there is a
// navigation away from the sign in flow that is not triggered by the
// web contents.
« no previous file with comments | « chrome/browser/ui/sync/one_click_signin_helper.cc ('k') | chrome/browser/ui/webui/signin/inline_login_handler_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698