Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 579007: Add generic wrappers for performing message digest operations. (Closed)

Created:
10 years, 10 months ago by gauravsh
Modified:
9 years, 6 months ago
Reviewers:
Chris Masone
CC:
chromium-os-reviews_googlegroups.com
Visibility:
Public.

Description

Add generic wrappers for performing message digest operations. A DigestContext structure now wraps state for all the SHA* algorithms. Replaced the old SHA*_file functions to use these new wrappers. Also moved the digest utility functions from tests/ to crypto/. BUG=670 TEST=Modified existing tests to use the new wrappers and they pass.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -151 lines) Patch
M src/platform/vboot_reference/crypto/Makefile View 1 chunk +1 line, -1 line 0 comments Download
A src/platform/vboot_reference/crypto/sha_utility.c View 1 chunk +129 lines, -0 lines 1 comment Download
A src/platform/vboot_reference/include/sha_utility.h View 1 chunk +53 lines, -0 lines 0 comments Download
M src/platform/vboot_reference/tests/Makefile View 2 chunks +4 lines, -7 lines 0 comments Download
D src/platform/vboot_reference/tests/digest_utility.h View 1 chunk +0 lines, -34 lines 0 comments Download
D src/platform/vboot_reference/tests/digest_utility.c View 1 chunk +0 lines, -105 lines 0 comments Download
M src/platform/vboot_reference/tests/signature_digest.c View 2 chunks +2 lines, -2 lines 0 comments Download
M src/platform/vboot_reference/tests/verify_data.c View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
gauravsh
10 years, 10 months ago (2010-02-05 22:01:34 UTC) #1
Chris Masone
10 years, 10 months ago (2010-02-05 22:22:39 UTC) #2
lgtm with that comment.

http://codereview.chromium.org/579007/diff/1/3
File src/platform/vboot_reference/crypto/sha_utility.c (right):

http://codereview.chromium.org/579007/diff/1/3#newcode111
src/platform/vboot_reference/crypto/sha_utility.c:111: uint8_t*
DigestBuf(uint8_t* buf, int len, int sig_algorithm) {
some comments explaining what's going on in this fcn might help those whose C-fu
is a bit weak.  Function pointers can be mindbending.

Powered by Google App Engine
This is Rietveld 408576698