Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 578893002: mojo: Fix dependency for building python bindings. (Closed)

Created:
6 years, 3 months ago by qsr
Modified:
6 years, 3 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mojo: Fix dependency for building python bindings. R=sdefresne@chromium.org Committed: https://crrev.com/fa0bbf3bfd9c57da2edf281ffe7e3da4c323e38e Cr-Commit-Position: refs/heads/master@{#295441}

Patch Set 1 #

Patch Set 2 : Remove unused variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -75 lines) Patch
M mojo/mojo.gyp View 1 chunk +33 lines, -0 lines 0 comments Download
D third_party/cython/cp_python_binary_modules.py View 1 chunk +0 lines, -46 lines 0 comments Download
M third_party/cython/cython_compiler.gypi View 1 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/cython/python_module.gypi View 1 2 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
qsr
6 years, 3 months ago (2014-09-17 16:41:56 UTC) #1
sdefresne
Code LGTM but I may miss the big picture there. I guess that the file ...
6 years, 3 months ago (2014-09-18 08:19:21 UTC) #2
qsr
On 2014/09/18 08:19:21, sdefresne wrote: > Code LGTM but I may miss the big picture ...
6 years, 3 months ago (2014-09-18 08:34:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/578893002/20001
6 years, 3 months ago (2014-09-18 08:43:17 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as b4a4154e75179b92cf66d90208abbf36c7d04703
6 years, 3 months ago (2014-09-18 10:07:11 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 10:56:07 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fa0bbf3bfd9c57da2edf281ffe7e3da4c323e38e
Cr-Commit-Position: refs/heads/master@{#295441}

Powered by Google App Engine
This is Rietveld 408576698