content/public/browser/content_browser_client.h - Issue 578883003: Remove the strict dependency on WebContents for Web Notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/content_browser_client.h

Issue 578883003: Remove the strict dependency on WebContents for Web Notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: plumb through render_process_id Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/shell/browser/layout_test/layout_test_content_browser_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/content_browser_client.h

diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h

index ac87e075ccc86f8dd5c521955eaeed1071a13852..353f2fe0750b56ab28440f11d8dd88acb8cd5ea9 100644

--- a/content/public/browser/content_browser_client.h

+++ b/content/public/browser/content_browser_client.h

@@ -436,7 +436,8 @@ class CONTENT_EXPORT ContentBrowserClient {

// a callback which can be used to cancel the notification.

virtual void ShowDesktopNotification(

const ShowDesktopNotificationHostMsgParams& params,

- RenderFrameHost* render_frame_host,

+ BrowserContext* browser_context,

+ int render_process_id,

scoped_ptr<DesktopNotificationDelegate> delegate,

base::Closure* cancel_callback) {}