chrome/browser/notifications/desktop_notification_service.h - Issue 578883003: Remove the strict dependency on WebContents for Web Notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/desktop_notification_service.h

Issue 578883003: Remove the strict dependency on WebContents for Web Notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: plumb through render_process_id Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/notifications/desktop_notification_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/desktop_notification_service.h

diff --git a/chrome/browser/notifications/desktop_notification_service.h b/chrome/browser/notifications/desktop_notification_service.h

index e323d1a53067e8675b74d1793da64a44ebc86df5..818e07bc71cc6b728bb0169189e912cb0d15502d 100644

--- a/chrome/browser/notifications/desktop_notification_service.h

+++ b/chrome/browser/notifications/desktop_notification_service.h

@@ -36,7 +36,6 @@ class Profile;

namespace content {

class DesktopNotificationDelegate;

-class RenderFrameHost;

struct ShowDesktopNotificationHostMsgParams;

}

@@ -95,7 +94,7 @@ class DesktopNotificationService : public PermissionContextBase

// a callback which can be used to cancel the notification.

void ShowDesktopNotification(

const content::ShowDesktopNotificationHostMsgParams& params,

- content::RenderFrameHost* render_frame_host,

+ int render_process_id,

scoped_ptr<content::DesktopNotificationDelegate> delegate,

base::Closure* cancel_callback);

« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/notifications/desktop_notification_service.cc » ('j') | no next file with comments »