android_webview/browser/aw_content_browser_client.cc - Issue 578883003: Remove the strict dependency on WebContents for Web Notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/aw_content_browser_client.cc

Issue 578883003: Remove the strict dependency on WebContents for Web Notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: plumb through render_process_id Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/browser/aw_content_browser_client.cc

diff --git a/android_webview/browser/aw_content_browser_client.cc b/android_webview/browser/aw_content_browser_client.cc

index 02029c3300c9603966d9266fc3009a98e8356aa3..879bc60c93dd576ad0d97985975296297d0f21a8 100644

--- a/android_webview/browser/aw_content_browser_client.cc

+++ b/android_webview/browser/aw_content_browser_client.cc

@@ -396,7 +396,8 @@ blink::WebNotificationPermission

void AwContentBrowserClient::ShowDesktopNotification(

const content::ShowDesktopNotificationHostMsgParams& params,

- content::RenderFrameHost* render_frame_host,

+ content::BrowserContext* browser_context,

+ int render_process_id,

scoped_ptr<content::DesktopNotificationDelegate> delegate,

base::Closure* cancel_callback) {

NOTREACHED() << "Android WebView does not support desktop notifications.";

« no previous file with comments | « android_webview/browser/aw_content_browser_client.h ('k') | chrome/browser/chrome_content_browser_client.h » ('j') | no next file with comments »