Remove the strict dependency on WebContents for Web Notifications.

chrome/browser/chrome_content_browser_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_content_browser_client.h"
 
 #include <set>
 #include <utility>
 #include <vector>
 
@@ skipping 1886 matching lines @@
   if (setting == CONTENT_SETTING_BLOCK)
     return blink::WebNotificationPermissionDenied;
   return blink::WebNotificationPermissionDefault;
 #else
   return blink::WebNotificationPermissionAllowed;
 #endif
 }
 
 void ChromeContentBrowserClient::ShowDesktopNotification(
     const content::ShowDesktopNotificationHostMsgParams& params,
-    RenderFrameHost* render_frame_host,
+    content::BrowserContext* browser_context,
     scoped_ptr<content::DesktopNotificationDelegate> delegate,
     base::Closure* cancel_callback) {
 #if defined(ENABLE_NOTIFICATIONS)
-  content::RenderProcessHost* process = render_frame_host->GetProcess();
-  Profile* profile = Profile::FromBrowserContext(process->GetBrowserContext());
+  Profile* profile = Profile::FromBrowserContext(browser_context);
   DesktopNotificationService* service =

[dewittj, 2014/09/17 16:58:48]

So DNS needs a Profile* (as opposed to a BrowserContext) because of
permissions/content settings, right?

[Peter Beverloo, 2014/09/17 17:06:06]

We use the preferences (Profile::GetPrefs()) and host content settings
(Profile::GetHostContentSettingsMap()). Chrome OS also uses the Profile to get
the User ID (GetUserIDFromProfile) to associate a
MessageCenterNotificationManager::ProfileNotification.

ExtensionWelcomeNotification also needs to be created using the profile_, but we
should be able to factor that out without too much trouble.

Everything else is happy with a BrowserContext.

       DesktopNotificationServiceFactory::GetForProfile(profile);
   service->ShowDesktopNotification(
-      params, render_frame_host, delegate.Pass(), cancel_callback);
+      params, delegate.Pass(), cancel_callback);

[Jun Mukai, 2014/09/18 18:00:59]

doesn't this fit into the previous line?

[Peter Beverloo, 2014/10/03 14:39:30]

Done.

 
   profile->GetHostContentSettingsMap()->UpdateLastUsage(
       params.origin, params.origin, CONTENT_SETTINGS_TYPE_NOTIFICATIONS);
 #else
   NOTIMPLEMENTED();
 #endif
 }
 
 void ChromeContentBrowserClient::RequestGeolocationPermission(
     content::WebContents* web_contents,
@@ skipping 664 matching lines @@
       switches::kDisableWebRtcEncryption,
     };
     to_command_line->CopySwitchesFrom(from_command_line,
                                       kWebRtcDevSwitchNames,
                                       arraysize(kWebRtcDevSwitchNames));
   }
 }
 #endif  // defined(ENABLE_WEBRTC)
 
 }  // namespace chrome