Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: content/browser/device_sensors/data_fetcher_shared_memory_base.h

Issue 578863002: Fix the indirect pure virtual calls in DataFetcherSharedMemoryBase destructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix unsigned 0 compilation Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/device_sensors/data_fetcher_shared_memory_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/device_sensors/data_fetcher_shared_memory_base.h
diff --git a/content/browser/device_sensors/data_fetcher_shared_memory_base.h b/content/browser/device_sensors/data_fetcher_shared_memory_base.h
index c959e8254fd6dfadb922289ce75e8e246663a1ec..fc1f031d49919785168247a0275b2b45113b7254 100644
--- a/content/browser/device_sensors/data_fetcher_shared_memory_base.h
+++ b/content/browser/device_sensors/data_fetcher_shared_memory_base.h
@@ -31,6 +31,10 @@ class CONTENT_EXPORT DataFetcherSharedMemoryBase {
// relevant sensors could be successfully deactivated.
bool StopFetchingDeviceData(ConsumerType consumer_type);
+ // Should be called before destruction to make sure all active
+ // sensors are unregistered.
+ void StopFetchingAllDeviceData();
+
// Returns the shared memory handle of the device sensor data
// duplicated into the given process. This method should only be
// called after a call to StartFetchingDeviceData method with
« no previous file with comments | « no previous file | content/browser/device_sensors/data_fetcher_shared_memory_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698