Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 57883004: Update command state on "load" of a folder (Closed)

Created:
7 years, 1 month ago by arv (Not doing code reviews)
Modified:
7 years, 1 month ago
Reviewers:
Tom Cassiotis, Dan Beam
CC:
chromium-reviews, tfarina, arv+watch_chromium.org
Visibility:
Public.

Description

Update command state on "load" of a folder We used to only update the command when selection changes. However, when a folder is loaded the selection does not change, it goes from [] to [] so no event is fired. However, we do have callbacks after the folder is populated. Use that to update the state of all the commands. BUG=313592 R=dbeam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233078

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Changes based on code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -26 lines) Patch
M chrome/browser/resources/bookmark_manager/js/main.js View 1 6 chunks +24 lines, -26 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
arv (Not doing code reviews)
I have another fix coming that takes care of the timing issues during startup.
7 years, 1 month ago (2013-11-04 20:50:48 UTC) #1
Dan Beam
lgtm https://codereview.chromium.org/57883004/diff/40001/chrome/browser/resources/bookmark_manager/js/main.js File chrome/browser/resources/bookmark_manager/js/main.js (right): https://codereview.chromium.org/57883004/diff/40001/chrome/browser/resources/bookmark_manager/js/main.js#newcode376 chrome/browser/resources/bookmark_manager/js/main.js:376: return list.dataModel.slice(); nit: if this is to make ...
7 years, 1 month ago (2013-11-04 22:19:21 UTC) #2
arv (Not doing code reviews)
https://codereview.chromium.org/57883004/diff/40001/chrome/browser/resources/bookmark_manager/js/main.js File chrome/browser/resources/bookmark_manager/js/main.js (right): https://codereview.chromium.org/57883004/diff/40001/chrome/browser/resources/bookmark_manager/js/main.js#newcode376 chrome/browser/resources/bookmark_manager/js/main.js:376: return list.dataModel.slice(); On 2013/11/04 22:19:21, Dan Beam wrote: > ...
7 years, 1 month ago (2013-11-04 22:29:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/57883004/90001
7 years, 1 month ago (2013-11-04 22:50:15 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=184543
7 years, 1 month ago (2013-11-05 02:35:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/57883004/90001
7 years, 1 month ago (2013-11-05 14:33:34 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=93952
7 years, 1 month ago (2013-11-05 18:42:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/57883004/90001
7 years, 1 month ago (2013-11-05 19:45:18 UTC) #8
arv (Not doing code reviews)
7 years, 1 month ago (2013-11-05 20:42:02 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 manually as r233078 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698