Add Wimax to ONC.

chromeos/network/network_state.cc

Index: chromeos/network/network_state.cc
diff --git a/chromeos/network/network_state.cc b/chromeos/network/network_state.cc
index c47068b719ca5f93cf4453f3001b83d6def4e2ae..915a688de3cdaa9c51afe49888bfdb6e5243b8db 100644
--- a/chromeos/network/network_state.cc
+++ b/chromeos/network/network_state.cc
@@ -163,9 +163,10 @@ bool NetworkState::InitialPropertiesReceived(
   has_ca_cert_nss_ = IsCaCertNssSet(properties);
   changed |= had_ca_cert_nss != has_ca_cert_nss_;
 
-  // By convention, all visible WiFi networks have a SignalStrength > 0.
-  if (visible() && type() == shill::kTypeWifi) {
-    if (signal_strength_ <= 0)
+  // By convention, all visible WiFi and WiMAX networks have a
+  // SignalStrength > 0.
+  if ((type() == shill::kTypeWifi || type() == shill::kTypeWimax) &&

[Ben Chan, 2014/09/17 22:51:38]

TODO: cellular has signal strength as well.

[pneubeck (no reviews), 2014/09/18 08:50:11]

Done.

[pneubeck (no reviews), 2014/09/18 09:23:01]

Actually, not done.
I checked Shill's side, and 'visible' of Cellular is always true. So cellular
would need a bit of special consideration: maybe set visible=false if
signal_strength <= 0?

But I'd like to keep that out of this CL, as it's unrelated.

[Ben Chan, 2014/09/18 14:57:06]

I wouldn't suggest adding cellular stuff in this CL.

I'm not sure if there has to be a relation between SignalStrength > 0 and
visible=true. shill guarantees that SignalStrength is within [0, 100]. I still
don't see why we'd specially handle WiFi/WiMAX but not cellular. But I'm ok if
we leave this as a TODO to further investigate.

+      visible() && signal_strength_ <= 0) {
       signal_strength_ = 1;
   }