Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: chromeos/network/network_state_handler.cc

Issue 578823003: Add Wimax to ONC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/network/network_state.cc ('k') | chromeos/network/onc/onc_signature.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/network_state_handler.cc
diff --git a/chromeos/network/network_state_handler.cc b/chromeos/network/network_state_handler.cc
index a78b6eebdaaa0044a1bbf463d11933531cc54307..ba4bc3284652c8368b546902840838ce6069e9aa 100644
--- a/chromeos/network/network_state_handler.cc
+++ b/chromeos/network/network_state_handler.cc
@@ -563,7 +563,7 @@ void NetworkStateHandler::UpdateNetworkServiceProperty(
std::string value_str;
value.GetAsString(&value_str);
// Some property changes are noisy and not interesting:
- // * Wifi SignalStrength
+ // * Wifi or WiMAX SignalStrength
// * WifiFrequencyList updates
// * Device property changes to "/" (occurs before a service is removed)
if (key != shill::kSignalStrengthProperty &&
@@ -703,6 +703,7 @@ void NetworkStateHandler::SortNetworkList() {
// Note: usually active networks will precede inactive networks, however
// this may briefly be untrue during state transitions (e.g. a network may
// transition to idle before the list is updated).
+ // Handle WiMAX in the same way as WiFi.
stevenjb 2014/09/17 16:49:04 nit: I think we should probably handle Wimax like
pneubeck (no reviews) 2014/09/17 20:10:47 Sorry, this is a leftover from me debugging the AP
ManagedStateList active, non_wifi_visible, wifi_visible, hidden, new_networks;
for (ManagedStateList::iterator iter = network_list_.begin();
iter != network_list_.end(); ++iter) {
@@ -716,10 +717,12 @@ void NetworkStateHandler::SortNetworkList() {
continue;
}
if (network->visible()) {
- if (NetworkTypePattern::WiFi().MatchesType(network->type()))
+ if (NetworkTypePattern::WiFi().MatchesType(network->type()) ||
+ NetworkTypePattern::Wimax().MatchesType(network->type())) {
wifi_visible.push_back(network);
- else
+ } else {
non_wifi_visible.push_back(network);
+ }
} else {
hidden.push_back(network);
}
« no previous file with comments | « chromeos/network/network_state.cc ('k') | chromeos/network/onc/onc_signature.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698