Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 578823002: Video Player: Show the status icon on display when the status is changed (Closed)

Created:
6 years, 3 months ago by yoshiki
Modified:
6 years, 3 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Video Player: Show the status icon on display when the status is changed This patch adds a feature to show the icon. See the issue for the detail. BUG=412978 TEST=manually tested Committed: https://crrev.com/c1165114767914b846c21f0a3f012d7ded0d96dd Cr-Commit-Position: refs/heads/master@{#295418}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -6 lines) Patch
M ui/file_manager/video_player/js/cast/cast_video_element.js View 1 2 chunks +27 lines, -4 lines 0 comments Download
M ui/file_manager/video_player/js/media_controls.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yoshiki
@fukino-san, PTAL. THanks.
6 years, 3 months ago (2014-09-18 02:23:15 UTC) #2
fukino
On 2014/09/18 02:23:15, yoshiki wrote: > @fukino-san, PTAL. THanks. lgtm.
6 years, 3 months ago (2014-09-18 03:25:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/578823002/20001
6 years, 3 months ago (2014-09-18 04:15:52 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 412dd51e30085ffc0bc4106d4a4b3938039664f0
6 years, 3 months ago (2014-09-18 05:20:22 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 05:20:51 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c1165114767914b846c21f0a3f012d7ded0d96dd
Cr-Commit-Position: refs/heads/master@{#295418}

Powered by Google App Engine
This is Rietveld 408576698