|
Revert of Second attempt to land change to remove NativeViewportService and (patchset #9 id:160001 of https://codereview.chromium.org/568883003/)
Reason for revert:
ViewManagerTest failure.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#master=chromium.win&testType=mojo_view_manager_unittests&tests=ViewManagerTest.AddAncestorFails,ViewManagerTest.AddViewWithNoChange,ViewManagerTest.CantAccessChildrenOfEmbeddedView,ViewManagerTest.CantGetViewTreeOfOtherRoots,ViewManagerTest.CantModifyChildrenOfEmbeddedView,ViewManagerTest.CantRemoveViewsInOtherRoots,ViewManagerTest.CreateView,ViewManagerTest.DeleteView,ViewManagerTest.DeleteViewFromAnotherConnectionDisallowed,ViewManagerTest.EmbedWithSameViewId,ViewManagerTest.EmbedWithSameViewId2,ViewManagerTest.MultipleEmbedRootsBeforeWTHReady,ViewManagerTest.OnViewInput,ViewManagerTest.ReorderView,ViewManagerTest.ReuseDeletedViewId,ViewManagerTest.SetViewVisibility,ViewManagerTest.SetViewVisibilityNotifications,ViewManagerTest.ViewHierarchyChangedAddingKnownToUnknown,ViewManagerTest.ViewHierarchyChangedViews,ViewManagerTest.ViewsRemovedWhenEmbedding
Original issue's description:
> Second attempt to land change to remove NativeViewportService and
> ViewManager from mojo_shell. First attempt here:
> https://codereview.chromium.org/477923004/
>
> Failed the linux gn dbg build after cq landed:
> http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/12251
>
> BUG=
> TBR=ben@chromium.org
>
> Committed: https://crrev.com/d3e622b0bb31f20c274bc9ad634b8ee7bae99ac1
> Cr-Commit-Position: refs/heads/master@{#295230}
TBR=jamesr@chromium.org,davemoore@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=
Committed: https://crrev.com/db2b72884a57f1598624f02cde34264a4b7e8829
Cr-Commit-Position: refs/heads/master@{#295245}
|
Unified diffs |
Side-by-side diffs |
Stats (+171 lines, -262 lines) |
 |
M |
mojo/aura/aura_init.cc
|
View
|
1 chunk |
+1 line, -1 line |
0 comments
|
 |
M |
mojo/mojo.gyp
|
View
|
10 chunks |
+37 lines, -14 lines |
0 comments
|
 |
M |
mojo/mojo_examples.gypi
|
View
|
5 chunks |
+5 lines, -1 line |
0 comments
|
 |
M |
mojo/mojo_services.gypi
|
View
|
11 chunks |
+13 lines, -30 lines |
0 comments
|
 |
M |
mojo/services/BUILD.gn
|
View
|
2 chunks |
+1 line, -4 lines |
0 comments
|
 |
M |
mojo/services/html_viewer/DEPS
|
View
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
 |
M |
mojo/services/html_viewer/html_viewer.cc
|
View
|
2 chunks |
+0 lines, -17 lines |
0 comments
|
 |
M |
mojo/services/native_viewport/BUILD.gn
|
View
|
3 chunks |
+10 lines, -16 lines |
0 comments
|
 |
M |
mojo/services/native_viewport/DEPS
|
View
|
1 chunk |
+0 lines, -1 line |
0 comments
|
 |
D |
mojo/services/native_viewport/main.cc
|
View
|
1 chunk |
+0 lines, -102 lines |
0 comments
|
 |
M |
mojo/services/public/cpp/view_manager/BUILD.gn
|
View
|
2 chunks |
+1 line, -4 lines |
0 comments
|
 |
M |
mojo/services/public/cpp/view_manager/lib/BUILD.gn
|
View
|
1 chunk |
+8 lines, -7 lines |
0 comments
|
 |
M |
mojo/services/public/cpp/view_manager/lib/view_manager_test_suite.cc
|
View
|
1 chunk |
+1 line, -4 lines |
0 comments
|
 |
M |
mojo/services/public/interfaces/native_viewport/native_viewport.mojom
|
View
|
1 chunk |
+0 lines, -7 lines |
0 comments
|
 |
M |
mojo/services/view_manager/BUILD.gn
|
View
|
3 chunks |
+5 lines, -11 lines |
0 comments
|
 |
M |
mojo/services/view_manager/ids.h
|
View
|
2 chunks |
+2 lines, -1 line |
0 comments
|
 |
M |
mojo/services/view_manager/view_manager_unittest.cc
|
View
|
3 chunks |
+7 lines, -11 lines |
0 comments
|
 |
M |
mojo/services/window_manager/BUILD.gn
|
View
|
2 chunks |
+6 lines, -1 line |
0 comments
|
 |
M |
mojo/shell/BUILD.gn
|
View
|
4 chunks |
+29 lines, -5 lines |
0 comments
|
 |
M |
mojo/shell/context.cc
|
View
|
4 chunks |
+25 lines, -5 lines |
0 comments
|
 |
M |
mojo/shell/desktop/mojo_main.cc
|
View
|
3 chunks |
+16 lines, -14 lines |
0 comments
|
 |
M |
mojo/shell/in_process_dynamic_service_runner.cc
|
View
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Total messages: 4 (0 generated)
|