ServiceWorker: Fix conversion from Request headers to WebServiceWorkerRequest headers

Source/platform/exported/WebServiceWorkerRequest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "public/platform/WebServiceWorkerRequest.h"
 
 #include "platform/blob/BlobData.h"
 #include "platform/weborigin/KURL.h"
 #include "public/platform/WebHTTPHeaderVisitor.h"
@@ skipping 42 matching lines @@
     m_private->m_method = method;
 }
 
 WebString WebServiceWorkerRequest::method() const
 {
     return m_private->m_method;
 }
 
 void WebServiceWorkerRequest::setHeader(const WebString& key, const WebString& value)
 {
+    ASSERT(String(key) == String(key).lower());

[horo, 2014/09/17 21:13:09]

The header key in content::ServiceWorkerFetchRequest is not lowercased.
So blink::WebServiceWorkerRequest::setHeader() called from
content::ServiceWorkerScriptContext::OnFetchEvent() will crash here.

[jkarlin, 2014/09/18 13:43:43]

Done. Removed lowercase requirement.  HTTPHeaderMap uses a casefolding hash so
lower is unnecessary.  I'll use a casefolding hash equivalent in the browser as
well.

     if (equalIgnoringCase(key, "referer"))
         return;
-    m_private->m_headers.add(key, value);
+    m_private->m_headers.set(key, value);
+}
+
+void WebServiceWorkerRequest::appendHeader(const WebString& key, const WebString& value)
+{
+    ASSERT(String(key) == String(key).lower());
+    if (equalIgnoringCase(key, "referer"))
+        return;
+    HTTPHeaderMap::AddResult result = m_private->m_headers.add(key, value);
+    if (!result.isNewEntry)
+        result.storedValue->value = result.storedValue->value + ", " + String(value);

[jochen (gone - plz use gerrit), 2014/09/17 19:21:28]

would it make sense to add a check that we only do this for headers where this
is valid?

or what happens if the same key/value pair is set multiple times? should we
still append?

[jkarlin, 2014/09/18 13:43:43]

Good question, and I don't have a good answer.  This CL makes Fetch behave like
Blink's WebURLLoaderImpl: 
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
which seems like a good starting place.
They'll be duplicated, which seems reasonable.  This is also the behavior of
WebURLLoader.

 }
 
 void WebServiceWorkerRequest::visitHTTPHeaderFields(WebHTTPHeaderVisitor* headerVisitor) const
 {
     for (HTTPHeaderMap::const_iterator i = m_private->m_headers.begin(), end = m_private->m_headers.end(); i != end; ++i)
         headerVisitor->visitHeader(i->key, i->value);
 }
 
 const HTTPHeaderMap& WebServiceWorkerRequest::headers() const
 {
@@ skipping 34 matching lines @@
 {
     m_private->m_isReload = isReload;
 }
 
 bool WebServiceWorkerRequest::isReload() const
 {
     return m_private->m_isReload;
 }
 
 } // namespace blink