Build new IR for functions returning a constant

sdk/lib/_internal/compiler/implementation/ir/ir_nodes.dart

Index: sdk/lib/_internal/compiler/implementation/ir/ir_nodes.dart
diff --git a/sdk/lib/_internal/compiler/implementation/ir/ir_nodes.dart b/sdk/lib/_internal/compiler/implementation/ir/ir_nodes.dart
new file mode 100644
index 0000000000000000000000000000000000000000..fce4829ba5a157ea9236f930450c8efeed91f473
--- /dev/null
+++ b/sdk/lib/_internal/compiler/implementation/ir/ir_nodes.dart
@@ -0,0 +1,76 @@
+// Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+// IrNodes are kept in a separate library to have precise control over their
+// dependencies on other parts of the system

[kasperl, 2013/11/25 11:32:54]

Terminate comment with .

[lukas, 2013/11/25 14:50:52]

Done.

+library ir_nodes;
+
+import '../dart2jslib.dart' show Constant;

[kasperl, 2013/11/25 11:32:54]

It's a little bit scary to drag in the entire Constant thing -- who knows what
kind of dependencies it has on the rest of the system. Maybe you'll have to
rework this once you start serializing/deserializing? 

[lukas, 2013/11/25 14:50:52]

Yes - I'll address this in the next CL which will introduce serialization.

+
+/**
+ * A pair of source offset and an identifier name. Identifier names are used in
+ * the Javascript backend to generate source maps.
+ */
+class PositionWithIdentifierName {
+  final int offset;
+  final String sourceName;
+  PositionWithIdentifierName(this.offset, this.sourceName);
+}
+
+abstract class IrNode {
+  final /* int | PositionWithIdentifierName */ position;
+
+  const IrNode(this.position);
+
+  int get offset =>
+      (position is PositionWithIdentifierName) ? position.offset : position;

[kasperl, 2013/11/25 11:32:54]

'is int' is simpler?

[lukas, 2013/11/25 14:50:52]

Done.

+
+  String get sourceName =>
+      (position is PositionWithIdentifierName) ? position.sourceName : null;
+
+  accept(IrNodesVisitor visitor);
+}
+
+class IrFunction extends IrNode {
+  final List<IrNode> statements;
+
+  final int endOffset;
+  final int namePosition;
+
+  IrFunction(position, this.endOffset, this.namePosition, this.statements)
+    : super(position);
+
+  accept(IrNodesVisitor visitor) => visitor.visitIrFunction(this);
+}
+
+class IrReturn extends IrNode {
+  final IrNode value;
+
+  IrReturn(position, this.value) : super(position);
+
+  accept(IrNodesVisitor visitor) => visitor.visitIrReturn(this);
+}
+
+class IrConstant extends IrNode {
+  final Constant value;
+
+  IrConstant(position, this.value) : super(position);
+
+  accept(IrNodesVisitor visitor) => visitor.visitIrConstant(this);
+}
+
+
+abstract class IrNodesVisitor<T> {
+  T visit(IrNode node) => node.accept(this);
+
+  void visitAll(List<IrNode> nodes) {
+    for (IrNode n in nodes) visit(n);
+  }
+
+  T visitNode(IrNode node);
+
+  T visitIrFunction(IrFunction node) => visitNode(node);
+  T visitIrReturn(IrReturn node) => visitNode(node);
+  T visitIrConstant(IrConstant node) => visitNode(node);
+}