Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 578653003: Add components_browsertests to trybot. (Closed)

Created:
6 years, 3 months ago by nyquist
Modified:
6 years, 3 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add components_browsertests to trybot. This CL adds the components_browsertests target to android, linux, mac and windows platforms. BUG=311270 Committed: https://crrev.com/12bec1740abec524ee2cee69fdb73acdc80fe8b0 Cr-Commit-Position: refs/heads/master@{#295199}

Patch Set 1 #

Patch Set 2 : remove android #

Total comments: 2

Patch Set 3 : Removed mentioning of platforms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M testing/buildbot/chromium_trybot.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
nyquist
phajdan.jr: PTAL
6 years, 3 months ago (2014-09-16 22:10:51 UTC) #2
Paweł Hajdan Jr.
https://codereview.chromium.org/578653003/diff/20001/testing/buildbot/chromium_trybot.json File testing/buildbot/chromium_trybot.json (right): https://codereview.chromium.org/578653003/diff/20001/testing/buildbot/chromium_trybot.json#newcode35 testing/buildbot/chromium_trybot.json:35: "platforms": ["linux", "mac", "win"] This is not needed since ...
6 years, 3 months ago (2014-09-16 22:31:56 UTC) #3
nyquist
phajdan.jr: PTAL https://codereview.chromium.org/578653003/diff/20001/testing/buildbot/chromium_trybot.json File testing/buildbot/chromium_trybot.json (right): https://codereview.chromium.org/578653003/diff/20001/testing/buildbot/chromium_trybot.json#newcode35 testing/buildbot/chromium_trybot.json:35: "platforms": ["linux", "mac", "win"] On 2014/09/16 22:31:56, ...
6 years, 3 months ago (2014-09-16 22:49:53 UTC) #4
Paweł Hajdan Jr.
LGTM
6 years, 3 months ago (2014-09-17 00:07:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/578653003/40001
6 years, 3 months ago (2014-09-17 00:20:21 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 20adfabc3375cba00449a3a803fab5215f294fa1
6 years, 3 months ago (2014-09-17 00:56:20 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 00:56:54 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/12bec1740abec524ee2cee69fdb73acdc80fe8b0
Cr-Commit-Position: refs/heads/master@{#295199}

Powered by Google App Engine
This is Rietveld 408576698