Issue 578643004: Redefine union-type subtyping to be more permissive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 578643004: Redefine union-type subtyping to be more permissive. (Closed)

Created:
6 years, 3 months ago by Nathan Collins

Modified:
6 years, 3 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Redefine union-type subtyping to be more permissive. Here "permissive" is a euphemism for "unsound". However, since our type analyses are sound rather than complete, the less permissive notion of union-type subtyping could in theory lead to hints where the user knows their code is correct. R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=40352

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -17 lines)			Patch
	M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/UnionTypeImpl.java	View		1 chunk	+35 lines, -7 lines	0 comments	Download
	M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/type/UnionTypeImplTest.java	View		2 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nathan Collins

6 years, 3 months ago (2014-09-16 21:51:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 40352 (presubmit successful).

Expand Messages | Collapse Messages