Chromium Code Reviews| Index: tools/perf/measurements/page_cycler_unittest.py |
| diff --git a/tools/perf/measurements/page_cycler_unittest.py b/tools/perf/measurements/page_cycler_unittest.py |
| index 89d0a5704cceb37892767ad4943be20bcea39b31..ea84745823c4892ce6ccb0aecc8950323e37056b 100644 |
| --- a/tools/perf/measurements/page_cycler_unittest.py |
| +++ b/tools/perf/measurements/page_cycler_unittest.py |
| @@ -49,21 +49,18 @@ class PageCyclerUnitTest(unittest.TestCase): |
| def testOptionsColdLoadNoArgs(self): |
|
tonyg
2013/11/06 18:31:49
I find the code a little hard to follow. Could we
|
| cycler = self.setupCycler([]) |
| - self.assertFalse(cycler._cold_runs_requested) |
| - self.assertEqual(cycler._number_warm_runs, 9) |
| + self.assertEquals(cycler._cold_run_start_index, 10) |
| def testOptionsColdLoadPagesetRepeat(self): |
| cycler = self.setupCycler(['--pageset-repeat=20', '--page-repeat=2']) |
| - self.assertFalse(cycler._cold_runs_requested) |
| - self.assertEqual(cycler._number_warm_runs, 38) |
| + self.assertEquals(cycler._cold_run_start_index, 40) |
| def testOptionsColdLoadRequested(self): |
| cycler = self.setupCycler(['--pageset-repeat=21', '--page-repeat=2', |
| '--cold-load-percent=40']) |
| - self.assertTrue(cycler._cold_runs_requested) |
| - self.assertEqual(cycler._number_warm_runs, 24) |
| + self.assertEquals(cycler._cold_run_start_index, 26) |
| def testIncompatibleOptions(self): |
| exception_seen = False |
| @@ -131,5 +128,5 @@ class PageCyclerUnitTest(unittest.TestCase): |
| self.assertEqual(result.values[0].trace_name, 'page_load_time') |
| self.assertEqual(result.values[0].units, 'ms') |
| self.assertEqual(result.values[0].chart_name, |
| - 'warm_times' if i < 3 else 'cold_times') |
| + 'warm_times' if i > 0 and i < 3 else 'cold_times') |
| cycler.DidNavigateToPage(page, tab) |