Update page cycler to differenciate between cold and warm run by default.

Update page cycler to differenciate between cold and warm run by default.

BUG=271176
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238374

[qsr, 2013-11-04 14:04:54]

This CL enables differentiating between cold and warm run by default on the page
cycler. The dashboard will have to be updated when it lands.

[sullivan, 2013-11-04 17:38:33]

lgtm

[qsr, 2013-11-05 09:05:00]

tonyg@ ping for OWNERS?

[tonyg, 2013-11-06 18:31:49]

https://codereview.chromium.org/57863002/diff/50001/tools/perf/measurements/p...
File tools/perf/measurements/page_cycler_unittest.py (right):

https://codereview.chromium.org/57863002/diff/50001/tools/perf/measurements/p...
tools/perf/measurements/page_cycler_unittest.py:49: def
testOptionsColdLoadNoArgs(self):
I find the code a little hard to follow. Could we add a test that confirms the
following (just to make sure my understanding is correct):

- PageSet with 2 URLs
- colod_load_percent is not passed in
- pageset_repeat is 3
- Verify that the first load of both URLs is reported as cold and the subsequent
2 loads of both URLs are reported as warm.

[qsr, 2013-11-27 11:08:26]

On 2013/11/06 18:31:49, tonyg wrote:
>
https://codereview.chromium.org/57863002/diff/50001/tools/perf/measurements/p...
> File tools/perf/measurements/page_cycler_unittest.py (right):
> 
>
https://codereview.chromium.org/57863002/diff/50001/tools/perf/measurements/p...
> tools/perf/measurements/page_cycler_unittest.py:49: def
> testOptionsColdLoadNoArgs(self):
> I find the code a little hard to follow. Could we add a test that confirms the
> following (just to make sure my understanding is correct):
> 
> - PageSet with 2 URLs
> - colod_load_percent is not passed in
> - pageset_repeat is 3
> - Verify that the first load of both URLs is reported as cold and the
subsequent
> 2 loads of both URLs are reported as warm.

 Test added. Can you take another look?

[qsr, 2013-11-29 09:46:04]

Gentle ping?

[tonyg, 2013-12-03 04:17:10]

lgtm

[commit-bot: I haz the power, 2013-12-03 09:29:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qsr@chromium.org/57863002/110001

[commit-bot: I haz the power, 2013-12-03 12:38:30]

Change committed as 238374