Roll Clang 214024:216630 (+216684) and switch to CMake (try 2)

tools/clang/plugins/FindBadConstructsAction.cpp

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "FindBadConstructsAction.h"
 
 #include "clang/Frontend/FrontendPluginRegistry.h"
 
 #include "FindBadConstructsConsumer.h"
 
 using namespace clang;
 
 namespace chrome_checker {
 
 FindBadConstructsAction::FindBadConstructsAction() {
 }
 
-ASTConsumer* FindBadConstructsAction::CreateASTConsumer(
+std::unique_ptr<ASTConsumer> FindBadConstructsAction::CreateASTConsumer(
     CompilerInstance& instance,
     llvm::StringRef ref) {
-  return new FindBadConstructsConsumer(instance, options_);
+  return llvm::make_unique<FindBadConstructsConsumer>(instance, options_);
 }
 
 bool FindBadConstructsAction::ParseArgs(const CompilerInstance& instance,
                                         const std::vector<std::string>& args) {
   bool parsed = true;
 
   for (size_t i = 0; i < args.size() && parsed; ++i) {
     if (args[i] == "skip-virtuals-in-implementations") {
       // TODO(rsleevi): Remove this once http://crbug.com/115047 is fixed.
       options_.check_virtuals_in_implementations = false;
@@ skipping 14 matching lines @@
   }
 
   return parsed;
 }
 
 }  // namespace chrome_checker
 
 static FrontendPluginRegistry::Add<chrome_checker::FindBadConstructsAction> X(
     "find-bad-constructs",
     "Finds bad C++ constructs");