Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1528)

Issue 578593002: Password bubble: get rid of hardcodeded sizes for username and password. (Closed)

Created:
6 years, 3 months ago by vasilii
Modified:
6 years, 3 months ago
Reviewers:
Mike West
CC:
chromium-reviews, tfarina, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Password bubble: get rid of hardcodeded sizes for username and password. BUG=411260 Committed: https://crrev.com/d575eafb4f112ed0c0f4be8cf58dfb8f71d4a142 Cr-Commit-Position: refs/heads/master@{#295086}

Patch Set 1 #

Patch Set 2 : remove includes #

Patch Set 3 : don't touch model #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -24 lines) Patch
M chrome/browser/ui/views/passwords/manage_password_item_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/passwords/manage_password_item_view.cc View 4 chunks +10 lines, -23 lines 1 comment Download

Messages

Total messages: 9 (2 generated)
vasilii
Mike, please review.
6 years, 3 months ago (2014-09-16 14:58:45 UTC) #2
Mike West
https://codereview.chromium.org/578593002/diff/40001/chrome/browser/ui/views/passwords/manage_password_item_view.cc File chrome/browser/ui/views/passwords/manage_password_item_view.cc (left): https://codereview.chromium.org/578593002/diff/40001/chrome/browser/ui/views/passwords/manage_password_item_view.cc#oldcode52 chrome/browser/ui/views/passwords/manage_password_item_view.cc:52: FirstFieldWidth()); Hrm. How does this end up looking? I'm ...
6 years, 3 months ago (2014-09-16 15:20:42 UTC) #3
vasilii
I uploaded them to the bug. Automatic spacing isn't worth than manual one.
6 years, 3 months ago (2014-09-16 16:18:48 UTC) #4
Mike West
On 2014/09/16 16:18:48, vasilii wrote: > I uploaded them to the bug. Automatic spacing isn't ...
6 years, 3 months ago (2014-09-16 16:29:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/578593002/40001
6 years, 3 months ago (2014-09-16 16:32:52 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as a537371c7672ec852efb1775cb38ab884fa6e66a
6 years, 3 months ago (2014-09-16 16:57:30 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 16:59:11 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d575eafb4f112ed0c0f4be8cf58dfb8f71d4a142
Cr-Commit-Position: refs/heads/master@{#295086}

Powered by Google App Engine
This is Rietveld 408576698