Issue 578563002: Remove createPath* from GrGpu and GrContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 578563002: Remove createPath* from GrGpu and GrContext (Closed)

Created:
6 years, 3 months ago by Chris Dalton

Modified:
6 years, 3 months ago

Reviewers:
bsalomon

CC:
reviews_skia.org, Kimmo Kinnunen

Base URL:
https://skia.googlesource.com/skia.git@upload_glyphmemorypath

Project:
skia

Visibility:
Public.

More Reviews

Description

Remove createPath* from GrGpu and GrContext Now that we have the GrPathRendering class, it doesn't make sense to have a bunch of shims on on GrGpu. This updates the path rendering clients to make calls directly on the GrPathRendering object. BUG=skia:2939 Committed: https://skia.googlesource.com/skia/+/4e205b10799730b887ae5d6ac7207570292c177f

Patch Set 1 #

Patch Set 2 : Simple quick change #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -52 lines)			Patch
M	include/gpu/GrContext.h	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View		1 chunk	+0 lines, -16 lines	0 comments	Download
M	src/gpu/GrGpu.h	View		1 chunk	+0 lines, -13 lines	0 comments	Download
M	src/gpu/GrGpu.cpp	View		1 chunk	+0 lines, -11 lines	0 comments	Download
M	src/gpu/GrPathRendering.h	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	src/gpu/GrStencilAndCoverPathRenderer.cpp	View	1	2 chunks	+13 lines, -2 lines	0 comments	Download
M	src/gpu/GrStencilAndCoverTextContext.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/578563002/20001

6 years, 3 months ago (2014-09-17 16:20:25 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-17 16:41:29 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as 4e205b10799730b887ae5d6ac7207570292c177f

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages