Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 578553004: Remove the "snionly" concept from the HSTS preload. (Closed)

Created:
6 years, 3 months ago by agl
Modified:
6 years, 2 months ago
Reviewers:
eroman, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove the "snionly" concept from the HSTS preload. The "snionly" tag only applies to preloaded values and only affects people who are forcing SSLv3 on the command line. (We no longer have the option in the preferences to disable TLS and the preference has been renamed so even those who might have set it in the past shouldn't have it now). It also complicates pending work to reduce the size of the preload data. BUG=102779 R=eroman@chromium.org, rsleevi@chromium.org Committed: https://crrev.com/5cbb7d7a2ce034432b7d56f5940009bc75c337d4 Cr-Commit-Position: refs/heads/master@{#296821}

Patch Set 1 #

Patch Set 2 : ... #

Patch Set 3 : ... #

Patch Set 4 : ... #

Total comments: 2

Patch Set 5 : ... #

Patch Set 6 : ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -257 lines) Patch
M chrome/browser/net/chrome_fraudulent_certificate_reporter.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/net/chrome_fraudulent_certificate_reporter.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/net/chrome_fraudulent_certificate_reporter_unittest.cc View 1 2 3 4 5 4 chunks +9 lines, -15 lines 0 comments Download
M chrome/browser/net/predictor.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_security_headers_unittest.cc View 10 chunks +14 lines, -20 lines 0 comments Download
M net/http/transport_security_persister_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/transport_security_state.h View 4 chunks +5 lines, -16 lines 0 comments Download
M net/http/transport_security_state.cc View 10 chunks +11 lines, -42 lines 0 comments Download
M net/http/transport_security_state_static.h View 1 2 3 4 4 chunks +10 lines, -14 lines 0 comments Download
M net/http/transport_security_state_static.json View 1 2 3 4 4 chunks +11 lines, -13 lines 0 comments Download
M net/http/transport_security_state_unittest.cc View 1 2 3 4 16 chunks +61 lines, -79 lines 0 comments Download
M net/quic/crypto/proof_verifier_chromium.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/socket/ssl_client_socket_openssl.cc View 1 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download
M net/socket_stream/socket_stream.cc View 1 chunk +1 line, -5 lines 0 comments Download
M net/socket_stream/socket_stream_job.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/spdy/spdy_session.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M net/ssl/ssl_config_service.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/ssl/ssl_config_service.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M net/url_request/fraudulent_certificate_reporter.h View 1 2 3 1 chunk +2 lines, -5 lines 0 comments Download
M net/url_request/url_request.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M net/url_request/url_request_http_job.cc View 1 2 3 4 2 chunks +2 lines, -7 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
agl
6 years, 3 months ago (2014-09-18 20:29:55 UTC) #2
palmer
Possible BUG= : https://code.google.com/p/chromium/issues/detail?id=102779 or https://code.google.com/p/chromium/issues/detail?id=113280
6 years, 3 months ago (2014-09-18 20:33:56 UTC) #3
eroman
lgtm for webui/net_internals/*
6 years, 3 months ago (2014-09-18 20:59:58 UTC) #5
agl
poke.
6 years, 2 months ago (2014-09-24 22:12:55 UTC) #6
Ryan Sleevi
LGTM. Sorry for the delays. https://codereview.chromium.org/578553004/diff/60001/net/http/transport_security_state_static.json File net/http/transport_security_state_static.json (right): https://codereview.chromium.org/578553004/diff/60001/net/http/transport_security_state_static.json#newcode1193 net/http/transport_security_state_static.json:1193: { "name": "www.rme.li", "mode": ...
6 years, 2 months ago (2014-09-25 17:50:37 UTC) #7
agl
https://codereview.chromium.org/578553004/diff/60001/net/http/transport_security_state_static.json File net/http/transport_security_state_static.json (right): https://codereview.chromium.org/578553004/diff/60001/net/http/transport_security_state_static.json#newcode1193 net/http/transport_security_state_static.json:1193: { "name": "www.rme.li", "mode": "force-https" } On 2014/09/25 17:50:37, ...
6 years, 2 months ago (2014-09-25 18:16:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/578553004/80001
6 years, 2 months ago (2014-09-25 18:53:25 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/12509) chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/13545)
6 years, 2 months ago (2014-09-25 19:06:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/578553004/100001
6 years, 2 months ago (2014-09-25 20:36:45 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/13581)
6 years, 2 months ago (2014-09-25 20:47:24 UTC) #16
agl
Committed patchset #6 (id:100001) manually as 5cbb7d7 (presubmit successful).
6 years, 2 months ago (2014-09-25 23:15:24 UTC) #17
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 23:15:39 UTC) #18
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/5cbb7d7a2ce034432b7d56f5940009bc75c337d4
Cr-Commit-Position: refs/heads/master@{#296821}

Powered by Google App Engine
This is Rietveld 408576698