Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 578533002: Removing remaining CrOS implicit conversions from scoped_refptr to T* (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
xiyuan, oshima
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, davemoore+watch_chromium.org, extensions-reviews_chromium.org, hashimoto+watch_chromium.org, kinuko+fileapi, nhiroki, nkostylev+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Removing remaining CrOS implicit conversions from scoped_refptr to T* Random fixups that the automated rewriting tool opted to skip. BUG=110610 Committed: https://crrev.com/f913653cd01a8b6390ad94c0ddb0de2dfd55bcdd Cr-Commit-Position: refs/heads/master@{#295135}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M athena/extensions/shell/extensions_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/fileapi/file_system_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/screenlock_icon_source.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/dbus/blocking_method_caller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/shill_client_unittest_base.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
dcheng
Followup to today's earlier CLs that were automatically generated. Hopefully I can disable the implicit ...
6 years, 3 months ago (2014-09-16 05:50:47 UTC) #2
oshima
rs lgtm
6 years, 3 months ago (2014-09-16 17:18:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/578533002/1
6 years, 3 months ago (2014-09-16 18:07:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/11323)
6 years, 3 months ago (2014-09-16 18:23:06 UTC) #7
dcheng
+xiyuan for the chrome/browser/ui/webui/chromeos changes.
6 years, 3 months ago (2014-09-16 19:48:11 UTC) #9
xiyuan
lgtm
6 years, 3 months ago (2014-09-16 19:52:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/578533002/1
6 years, 3 months ago (2014-09-16 20:03:48 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as 5dd3fac6838939da87093f1cd62db7d04af37bc1
6 years, 3 months ago (2014-09-16 20:10:13 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 20:10:43 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f913653cd01a8b6390ad94c0ddb0de2dfd55bcdd
Cr-Commit-Position: refs/heads/master@{#295135}

Powered by Google App Engine
This is Rietveld 408576698