Pass on the unsupported option to install-build-deps.sh if supplied during android deps install.

Pass on the args to install-build-deps.sh during android deps install.

While installing on non-ubuntu systems, the shell script,
build/install-build-deps.sh has an option '--unsupported' to override
the system checks. The same is not applied while installing the android
deps. The parameters to install-build-deps-android.sh should be passed
on to install-build-deps.sh.

R=thakis@chromium.org
NOTRY=true

Committed: https://crrev.com/7e300f8e14c22e315eb1af28e9fe57c4ebcb13ef
Cr-Commit-Position: refs/heads/master@{#295088}

[vivekg, 2014-09-16 03:27:36]

vivekg@chromium.org changed reviewers:
+ vivekg@chromium.org

[vivekg, 2014-09-16 03:27:37]

PTAL, thank you!

[vivekg, 2014-09-16 03:27:59]

vivekg@chromium.org changed reviewers:
- vivekg@chromium.org

[Nico, 2014-09-16 16:40:26]

lgtm

[vivekg, 2014-09-16 16:40:58]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2014-09-16 16:41:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/578503002/1

[Primiano Tucci (use gerrit), 2014-09-16 16:47:06]

primiano@chromium.org changed reviewers:
+ primiano@chromium.org

[Primiano Tucci (use gerrit), 2014-09-16 16:47:07]

https://codereview.chromium.org/578503002/diff/1/build/install-build-deps-and...
File build/install-build-deps-android.sh (right):

https://codereview.chromium.org/578503002/diff/1/build/install-build-deps-and...
build/install-build-deps-android.sh:22: --no-syms --no-arm --no-chromeos-fonts
--no-nacl --no-prompt $@
In general what you really want is "$@" which, conversely to what it looks like,
has the special semantic of quoting the individual arguments.
In other words, in the current cl, if you invoke
./install-build-deps-android.sh --weird-arg "Foo Bar"
this will invoke
./install-build-deps --weird-arg Foo Bar, which will have a different semantic.

Having said that, no need to change this if it's too late, the case of args with
spaces should be rare. However, if you're really willing of adding another
patchset (provided that you're still in time) "$@" is safer :-)

[vivekg, 2014-09-16 16:49:01]

The CQ bit was unchecked by vivekg@chromium.org

[vivekg, 2014-09-16 16:55:19]

On 2014/09/16 at 16:47:07, primiano wrote:
>
https://codereview.chromium.org/578503002/diff/1/build/install-build-deps-and...
> File build/install-build-deps-android.sh (right):
> 
>
https://codereview.chromium.org/578503002/diff/1/build/install-build-deps-and...
> build/install-build-deps-android.sh:22: --no-syms --no-arm --no-chromeos-fonts
--no-nacl --no-prompt $@
> In general what you really want is "$@" which, conversely to what it looks
like, has the special semantic of quoting the individual arguments.
> In other words, in the current cl, if you invoke
> ./install-build-deps-android.sh --weird-arg "Foo Bar"
> this will invoke
> ./install-build-deps --weird-arg Foo Bar, which will have a different
semantic.
> 
> Having said that, no need to change this if it's too late, the case of args
with spaces should be rare. However, if you're really willing of adding another
patchset (provided that you're still in time) "$@" is safer :-)

Thanks for your feedback. Updated the patch. PTAL.

[Primiano Tucci (use gerrit), 2014-09-16 16:57:51]

Thanks LGTM.
Note: you can add NOTRY=true after BUG= and save both time and CQ resources
(this script is not tested by the Commit Queue)

[vivekg, 2014-09-16 17:00:46]

The CQ bit was checked by vivekg@chromium.org

[Primiano Tucci (use gerrit), 2014-09-16 17:00:57]

Ah also you might want to format the commit message to wrap @ 72 cols as usual.
(I know, my ocd is terrible :) )

[vivekg, 2014-09-16 17:01:23]

The CQ bit was unchecked by vivekg@chromium.org

[vivekg, 2014-09-16 17:03:31]

On 2014/09/16 at 17:00:57, primiano wrote:
> Ah also you might want to format the commit message to wrap @ 72 cols as
usual. (I know, my ocd is terrible :) )

Done. :)

[Primiano Tucci (use gerrit), 2014-09-16 17:04:37]

> Done. :)
Many thanks! Much appreciate the patience. I'm closing my laptop now, I promise
:)

[vivekg, 2014-09-16 17:05:45]

On 2014/09/16 at 17:04:37, primiano wrote:
> > Done. :)
> Many thanks! Much appreciate the patience. I'm closing my laptop now, I
promise :)

hehe no worries. Thanks for your time! :)

[vivekg, 2014-09-16 17:06:22]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2014-09-16 17:07:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/578503002/20001

[commit-bot: I haz the power, 2014-09-16 17:09:25]

Committed patchset #2 (id:20001) as bd8fe2c06ec6f6259508bb055871a2142e5a11a1

[commit-bot: I haz the power, 2014-09-16 17:10:41]

Patchset 2 (id:??) landed as
https://crrev.com/7e300f8e14c22e315eb1af28e9fe57c4ebcb13ef
Cr-Commit-Position: refs/heads/master@{#295088}