Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 578483002: Cleanup: Only build extensions renderer code when extensions are enabled. (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Only build extensions renderer code when extensions are enabled. BUG=402728 Committed: https://crrev.com/a7e3c07f4bfada5410b7f5d06263dc5aafae98d9 Cr-Commit-Position: refs/heads/master@{#294974}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -135 lines) Patch
M chrome/chrome_renderer.gypi View 5 chunks +21 lines, -19 lines 0 comments Download
M chrome/renderer/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 3 chunks +3 lines, -1 line 0 comments Download
M chrome/renderer/chrome_render_process_observer.cc View 3 chunks +8 lines, -1 line 0 comments Download
M extensions/extensions.gyp View 3 chunks +47 lines, -57 lines 0 comments Download
M extensions/renderer/BUILD.gn View 4 chunks +47 lines, -56 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Lei Zhang
Wee!
6 years, 3 months ago (2014-09-16 00:01:03 UTC) #3
Yoyo Zhou
LGTM!
6 years, 3 months ago (2014-09-16 00:29:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/578483002/20001
6 years, 3 months ago (2014-09-16 00:37:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001) as e3852abd044c1571da724cf222755f1821eea5d1
6 years, 3 months ago (2014-09-16 02:09:44 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 02:13:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a7e3c07f4bfada5410b7f5d06263dc5aafae98d9
Cr-Commit-Position: refs/heads/master@{#294974}

Powered by Google App Engine
This is Rietveld 408576698