Support old-space allocation in generated code (bump block only for now).

runtime/vm/heap.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/heap.h"
 
 #include "platform/assert.h"
 #include "platform/utils.h"
 #include "vm/flags.h"
 #include "vm/isolate.h"
@@ skipping 19 matching lines @@
             "Enables heap verification before GC.");
 DEFINE_FLAG(bool, verify_after_gc, false,
             "Enables heap verification after GC.");
 DEFINE_FLAG(bool, gc_at_alloc, false, "GC at every allocation.");
 DEFINE_FLAG(int, new_gen_ext_limit, 64,
             "maximum total external size (MB) in new gen before triggering GC");
 DEFINE_FLAG(int, pretenure_threshold, 98,
             "Trigger pretenuring when this many percent are promoted.");
 DEFINE_FLAG(int, pretenure_interval, 10,
             "Back off pretenuring after this many cycles.");
+DEFINE_FLAG(bool, pretenure_all, false, "Global pretenuring (for testing).");
 
 Heap::Heap(Isolate* isolate,
            intptr_t max_new_gen_semi_words,
            intptr_t max_old_gen_words)
     : isolate_(isolate),
       read_only_(false),
       gc_in_progress_(false),
       pretenure_policy_(0) {
   for (int sel = 0;
        sel < kNumWeakSelectors;
@@ skipping 336 matching lines @@
 }
 
 
 void Heap::WriteProtect(bool read_only) {
   read_only_ = read_only;
   new_space_->WriteProtect(read_only);
   old_space_->WriteProtect(read_only);
 }
 
 
-uword Heap::TopAddress() {
-  return reinterpret_cast<uword>(new_space_->TopAddress());
+uword Heap::TopAddress(Heap::Space space) {
+  if (space == kNew) {
+    return reinterpret_cast<uword>(new_space_->TopAddress());
+  } else {
+    ASSERT(space == kPretenured);

[Ivan Posva, 2014/09/19 18:45:55]

Please add a TODO to the definition of kPretenured to mark the fact that this is
a temporary solution.

[koda, 2014/09/19 20:48:29]

Done.

+    return reinterpret_cast<uword>(old_space_->TopAddress());
+  }
 }
 
 
-uword Heap::EndAddress() {
-  return reinterpret_cast<uword>(new_space_->EndAddress());
+uword Heap::EndAddress(Heap::Space space) {
+  if (space == kNew) {
+    return reinterpret_cast<uword>(new_space_->EndAddress());
+  } else {
+    ASSERT(space == kPretenured);
+    return reinterpret_cast<uword>(old_space_->EndAddress());
+  }
+}
+
+
+Heap::Space Heap::SpaceForAllocation(intptr_t cid) const {
+  return FLAG_pretenure_all ? kPretenured : kNew;
 }
 
 
 void Heap::Init(Isolate* isolate,
                 intptr_t max_new_gen_words,
                 intptr_t max_old_gen_words) {
   ASSERT(isolate->heap() == NULL);
   Heap* heap = new Heap(isolate, max_new_gen_words, max_old_gen_words);
   isolate->set_heap(heap);
 }
@@ skipping 275 matching lines @@
     heap->DisableGrowthControl();
 }
 
 
 NoHeapGrowthControlScope::~NoHeapGrowthControlScope() {
     Heap* heap = reinterpret_cast<Isolate*>(isolate())->heap();
     heap->SetGrowthControlState(current_growth_controller_state_);
 }
 
 }  // namespace dart