Added PRESUBMIT check running gclient VERIFY.

Added PRESUBMIT check running gclient VERIFY.

BUG=371012
Committed: https://crrev.com/ef66469a9ac5f4f0628e93fd6e352c18fbcd8359
Cr-Commit-Position: refs/heads/master@{#296184}

[tandrii(chromium), 2014-09-18 19:47:43]

tandrii@chromium.org changed reviewers:
+ iannucci@chromium.org

[tandrii(chromium), 2014-09-18 19:47:44]

PTAL

This expects gclient verify to exist, that is
https://codereview.chromium.org/562953002 must be committed first.

[tandrii(chromium), 2014-09-18 20:00:59]

tandrii@chromium.org changed reviewers:
+ sergiyb@chromium.org

[iannucci, 2014-09-18 21:05:13]

https://codereview.chromium.org/578423002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/578423002/diff/1/PRESUBMIT.py#newcode404
PRESUBMIT.py:404: break
why not

if 'DEPS' not in input_api.AffectedFiles():
  return []

since we really care about the root one?

https://codereview.chromium.org/578423002/diff/1/PRESUBMIT.py#newcode417
PRESUBMIT.py:417: long_text=error.output or error.stdout)]
ugh, this is exactly what I'm worried about.

[tandrii(chromium), 2014-09-18 22:01:36]

Updated CL.

https://codereview.chromium.org/578423002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/578423002/diff/1/PRESUBMIT.py#newcode404
PRESUBMIT.py:404: break
On 2014/09/18 21:05:13, iannucci wrote:
> why not
> 
> if 'DEPS' not in input_api.AffectedFiles():
>   return []
> 
> since we really care about the root one?

Good point, though AffectedFiles() isn't a list of LocalPaths.

https://codereview.chromium.org/578423002/diff/1/PRESUBMIT.py#newcode417
PRESUBMIT.py:417: long_text=error.output or error.stdout)]
On 2014/09/18 21:05:13, iannucci wrote:
> ugh, this is exactly what I'm worried about.

As you have already seen, https://codereview.chromium.org/582933002/ attempts to
fix that. I'd rather remove the "or" and leave one. Since that CL is not yet
committed, I made this CL future-proof with "or".

[tandrii(chromium), 2014-09-19 12:57:04]

Since subprocess CL is committed, I've simplified this code.

PTAL

[Sergiy Byelozyorov, 2014-09-22 13:33:03]

lgtm

[iannucci, 2014-09-22 17:47:49]

lgtm

[tandrii(chromium), 2014-09-23 11:54:26]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2014-09-23 11:54:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/578423002/50001

[commit-bot: I haz the power, 2014-09-23 12:04:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-23 12:04:32]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tandrii(chromium), 2014-09-23 12:23:25]

tandrii@chromium.org changed reviewers:
+ jochen@chromium.org

[tandrii(chromium), 2014-09-23 12:23:25]

jochen@ can you please give Owner's approval?

[jochen (gone - plz use gerrit), 2014-09-23 12:31:31]

lgtm

[tandrii(chromium), 2014-09-23 14:46:08]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2014-09-23 14:47:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/578423002/50001

[commit-bot: I haz the power, 2014-09-23 14:51:53]

Committed patchset #4 (id:50001) as 6120375c064da6211bf6c19849b19f519cb66c45

[commit-bot: I haz the power, 2014-09-23 14:52:33]

Patchset 4 (id:??) landed as
https://crrev.com/ef66469a9ac5f4f0628e93fd6e352c18fbcd8359
Cr-Commit-Position: refs/heads/master@{#296184}