Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 578413002: Remove chrome.dll.pdb from isolate file because it's not there on the bots. (Closed)

Created:
6 years, 3 months ago by jam
Modified:
6 years, 3 months ago
CC:
chromium-reviews, Ken Russell (switch to Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove chrome.dll.pdb from isolate file because it's not there on the bots. This is breaking after r295514 which enforces that every file listed in an isolate file exists. BUG=414808 R=zmo@chromium.org Committed: https://crrev.com/0f47229d3dc4b4a7f2a5fc47c84d29c2d9b15db6 Cr-Commit-Position: refs/heads/master@{#295533}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/telemetry_gpu_test.isolate View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
jam
6 years, 3 months ago (2014-09-18 19:46:30 UTC) #3
Zhenyao Mo
LGTM
6 years, 3 months ago (2014-09-18 19:46:30 UTC) #4
Zhenyao Mo
kbr: FYI.
6 years, 3 months ago (2014-09-18 19:48:50 UTC) #5
jam
Committed patchset #1 (id:1) manually as 0f47229 (presubmit successful).
6 years, 3 months ago (2014-09-18 19:49:04 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0f47229d3dc4b4a7f2a5fc47c84d29c2d9b15db6 Cr-Commit-Position: refs/heads/master@{#295533}
6 years, 3 months ago (2014-09-18 19:49:14 UTC) #7
Ken Russell (switch to Gerrit)
LGTM to unblock broken builds, but doesn't this file exist on the debug GPU bots, ...
6 years, 3 months ago (2014-09-18 20:01:55 UTC) #9
jam
6 years, 3 months ago (2014-09-19 00:19:46 UTC) #10
Message was sent while issue was closed.
On 2014/09/18 20:01:55, Ken Russell wrote:
> LGTM to unblock broken builds, but doesn't this file exist on the debug GPU
> bots, which build the component build?

It was the GPU debug bot which had this failure, see the broken compiles here:
http://build.chromium.org/p/chromium.gpu/builders/GPU%20Win%20Builder%20%28db...

I had SSHd to the bots to verify that the pdb files that I removed weren't in
the output directory.

> We'd like to have as many symbols
> available as reasonable, so that crashes on the bots and try servers are
> diagnosable.

Yep agreed. I don't know why these files aren't there on the bots; I defer to
you guys for figuring that out. I'm just only looking at having the isolate
files match what's built.

Powered by Google App Engine
This is Rietveld 408576698