mac: Only show the access Address Book prompt a fixed number of times.

components/autofill/core/browser/personal_data_manager_mac.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/personal_data_manager.h"
 
 #include <math.h>
 
 #import <AddressBook/AddressBook.h>
 
@@ skipping 13 matching lines @@
 #include "components/autofill/core/browser/form_structure.h"
 #include "components/autofill/core/browser/phone_number.h"
 #include "components/autofill/core/common/autofill_pref_names.h"
 #include "components/autofill/core/common/form_data.h"
 #include "grit/components_strings.h"
 #include "ui/base/l10n/l10n_util_mac.h"
 
 namespace autofill {
 namespace {
 
+// The maximum number of instances when the access Address Book prompt should
+// be shown.
+int kMaxTimesToShowMacAddressBook = 5;
+
 // There is an uncommon sequence of events that causes the Address Book
 // permissions dialog to appear more than once for a given install of Chrome.
 //  1. Chrome has previously presented the Address Book permissions dialog.
 //  2. Chrome is launched.
 //  3. Chrome performs an auto-update, and changes its binary.
 //  4. Chrome attempts to access the Address Book for the first time since (2).
 // This sequence of events is rare because Chrome attempts to acess the Address
 // Book when the user focuses most form fields, so (4) generally occurs before
 // (3). For more details, see http://crbug.com/381763.
 //
 // When this sequence of events does occur, Chrome should not attempt to access
 // the Address Book unless the user explicitly asks Chrome to do so. The
 // jarring nature of the permissions dialog is worse than the potential benefit
 // of pulling information from the Address Book.
 //
 // Set to true after the Address Book is accessed for the first time.
 static bool g_accessed_address_book = false;
 
 // Set to true after the Chrome binary has been changed.
 static bool g_binary_changed = false;
 
 const char kAddressBookOrigin[] = "OS X Address Book";
 
-// Whether Chrome has prompted the user for permission to access the user's
-// address book.
-bool HasPromptedForAccessToAddressBook(PrefService* pref_service) {
+// Whether Chrome has attempted to access the Mac Address Book.
+bool HasQueriedMacAddressBook(PrefService* pref_service) {
   return pref_service->GetBoolean(prefs::kAutofillMacAddressBookQueried);
 }
 
 // Whether the user wants Chrome to use the AddressBook to populate Autofill
 // entries.
 bool ShouldUseAddressBook(PrefService* pref_service) {
   return pref_service->GetBoolean(prefs::kAutofillUseMacAddressBook);
 }
 
 // Records a UMA metric indicating whether an attempt to access the Address
 // Book was skipped because doing so would cause the Address Book permissions
 // prompt to incorrectly appear.
 void RecordAccessSkipped(bool skipped) {
   UMA_HISTOGRAM_BOOLEAN("Autofill.AddressBook.AccessSkipped", skipped);
 }
 
 ABAddressBook* GetAddressBook(PrefService* pref_service) {
-  bool first_access = !HasPromptedForAccessToAddressBook(pref_service);
+  bool first_access = !HasQueriedMacAddressBook(pref_service);
 
   // +[ABAddressBook sharedAddressBook] throws an exception internally in
   // circumstances that aren't clear. The exceptions are only observed in crash
   // reports, so it is unknown whether they would be caught by AppKit and nil
   // returned, or if they would take down the app. In either case, avoid
   // crashing. http://crbug.com/129022
   ABAddressBook* addressBook = base::mac::RunBlockIgnoringExceptions(
       ^{ return [ABAddressBook sharedAddressBook]; });
   UMA_HISTOGRAM_BOOLEAN("Autofill.AddressBookAvailable", addressBook != nil);
 
@@ skipping 276 matching lines @@
 bool PersonalDataManager::ShouldShowAccessAddressBookSuggestion(
     AutofillType type) {
   // Don't show the access Address Book prompt if the user has built up any
   // Autofill state.
   if (!web_profiles_.empty())
     return false;
 
   if (!enabled_pref_->GetValue())
     return false;
 
-  if (HasPromptedForAccessToAddressBook(pref_service_))
+  if (HasQueriedMacAddressBook(pref_service_))
+    return false;
+
+  if (AccessAddressBookPromptCount() >= kMaxTimesToShowMacAddressBook)
     return false;
 
   switch (type.group()) {
     case ADDRESS_BILLING:
     case ADDRESS_HOME:
     case EMAIL:
     case NAME:
     case NAME_BILLING:
     case PHONE_BILLING:
     case PHONE_HOME:
       return true;
     case NO_GROUP:
     case COMPANY:
     case CREDIT_CARD:
     case PASSWORD_FIELD:
     case TRANSACTION:
       return false;
   }
 
   return false;
 }
 
+void PersonalDataManager::ShowedAccessAddressBookPrompt() {
+  pref_service_->SetInteger(prefs::kAutofillMacAddressBookShowedCount,
+                            AccessAddressBookPromptCount() + 1);
+}
+
+int PersonalDataManager::AccessAddressBookPromptCount() {
+  return pref_service_->GetInteger(prefs::kAutofillMacAddressBookShowedCount);
+}
+
 void PersonalDataManager::BinaryChanging() {
   g_binary_changed = true;
 }
 
 }  // namespace autofill