Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Side by Side Diff: components/autofill/core/browser/personal_data_manager.h

Issue 578383002: mac: Only show the access Address Book prompt a fixed number of times. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@autofill-contacts
Patch Set: Comments from isherman, round 2. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_PERSONAL_DATA_MANAGER_H_ 5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_PERSONAL_DATA_MANAGER_H_
6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_PERSONAL_DATA_MANAGER_H_ 6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_PERSONAL_DATA_MANAGER_H_
7 7
8 #include <set> 8 #include <set>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 // If Chrome has not prompted for access to the user's address book, the 204 // If Chrome has not prompted for access to the user's address book, the
205 // method prompts the user for permission and blocks the process. Otherwise, 205 // method prompts the user for permission and blocks the process. Otherwise,
206 // this method has no effect. The return value reflects whether the user was 206 // this method has no effect. The return value reflects whether the user was
207 // prompted with a modal dialog. 207 // prompted with a modal dialog.
208 bool AccessAddressBook(); 208 bool AccessAddressBook();
209 209
210 // Whether an autofill suggestion should be displayed to prompt the user to 210 // Whether an autofill suggestion should be displayed to prompt the user to
211 // grant Chrome access to the user's address book. 211 // grant Chrome access to the user's address book.
212 bool ShouldShowAccessAddressBookSuggestion(AutofillType type); 212 bool ShouldShowAccessAddressBookSuggestion(AutofillType type);
213 213
214 // The access Address Book prompt was shown for a form.
215 void ShowedAccessAddressBookPrompt();
216
217 // The number of times that the access address book prompt was shown.
218 int AccessAddressBookPromptCount();
219
214 // The Chrome binary is in the process of being changed, or has been changed. 220 // The Chrome binary is in the process of being changed, or has been changed.
215 // Future attempts to access the Address Book might incorrectly present a 221 // Future attempts to access the Address Book might incorrectly present a
216 // blocking dialog. 222 // blocking dialog.
217 void BinaryChanging(); 223 void BinaryChanging();
218 #endif // defined(OS_MACOSX) && !defined(OS_IOS) 224 #endif // defined(OS_MACOSX) && !defined(OS_IOS)
219 225
220 protected: 226 protected:
221 // Only PersonalDataManagerFactory and certain tests can create instances of 227 // Only PersonalDataManagerFactory and certain tests can create instances of
222 // PersonalDataManager. 228 // PersonalDataManager.
223 FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, FirstMiddleLast); 229 FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, FirstMiddleLast);
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
367 373
368 // An observer to listen for changes to prefs::kAutofillEnabled. 374 // An observer to listen for changes to prefs::kAutofillEnabled.
369 scoped_ptr<BooleanPrefMember> enabled_pref_; 375 scoped_ptr<BooleanPrefMember> enabled_pref_;
370 376
371 DISALLOW_COPY_AND_ASSIGN(PersonalDataManager); 377 DISALLOW_COPY_AND_ASSIGN(PersonalDataManager);
372 }; 378 };
373 379
374 } // namespace autofill 380 } // namespace autofill
375 381
376 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_PERSONAL_DATA_MANAGER_H_ 382 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_PERSONAL_DATA_MANAGER_H_
OLDNEW
« no previous file with comments | « components/autofill/core/browser/autofill_manager.cc ('k') | components/autofill/core/browser/personal_data_manager_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698