Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: components/autofill/core/browser/autofill_manager.cc

Issue 578383002: mac: Only show the access Address Book prompt a fixed number of times. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@autofill-contacts
Patch Set: Comments from isherman, round 2. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/autofill/core/browser/autofill_manager.h" 5 #include "components/autofill/core/browser/autofill_manager.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <limits> 9 #include <limits>
10 #include <map> 10 #include <map>
(...skipping 212 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 registry->RegisterDoublePref( 223 registry->RegisterDoublePref(
224 prefs::kAutofillNegativeUploadRate, 224 prefs::kAutofillNegativeUploadRate,
225 kAutofillNegativeUploadRateDefaultValue, 225 kAutofillNegativeUploadRateDefaultValue,
226 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF); 226 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
227 227
228 #if defined(OS_MACOSX) && !defined(OS_IOS) 228 #if defined(OS_MACOSX) && !defined(OS_IOS)
229 registry->RegisterBooleanPref( 229 registry->RegisterBooleanPref(
230 prefs::kAutofillUseMacAddressBook, 230 prefs::kAutofillUseMacAddressBook,
231 false, 231 false,
232 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF); 232 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
233 registry->RegisterIntegerPref(
234 prefs::kAutofillMacAddressBookShowedCount,
235 0,
236 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
233 #endif // defined(OS_MACOSX) && !defined(OS_IOS) 237 #endif // defined(OS_MACOSX) && !defined(OS_IOS)
234 } 238 }
235 239
236 #if defined(OS_MACOSX) && !defined(OS_IOS) 240 #if defined(OS_MACOSX) && !defined(OS_IOS)
237 void AutofillManager::MigrateUserPrefs(PrefService* prefs) { 241 void AutofillManager::MigrateUserPrefs(PrefService* prefs) {
238 const PrefService::Preference* pref = 242 const PrefService::Preference* pref =
239 prefs->FindPreference(prefs::kAutofillUseMacAddressBook); 243 prefs->FindPreference(prefs::kAutofillUseMacAddressBook);
240 244
241 // If the pref is not its default value, then the migration has already been 245 // If the pref is not its default value, then the migration has already been
242 // performed. 246 // performed.
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
298 302
299 return personal_data_->ShouldShowAccessAddressBookSuggestion( 303 return personal_data_->ShouldShowAccessAddressBookSuggestion(
300 autofill_field->Type()); 304 autofill_field->Type());
301 } 305 }
302 306
303 bool AutofillManager::AccessAddressBook() { 307 bool AutofillManager::AccessAddressBook() {
304 if (!personal_data_) 308 if (!personal_data_)
305 return false; 309 return false;
306 return personal_data_->AccessAddressBook(); 310 return personal_data_->AccessAddressBook();
307 } 311 }
312
313 void AutofillManager::ShowedAccessAddressBookPrompt() {
314 if (!personal_data_)
315 return;
316 return personal_data_->ShowedAccessAddressBookPrompt();
317 }
318
319 int AutofillManager::AccessAddressBookPromptCount() {
320 if (!personal_data_)
321 return 0;
322 return personal_data_->AccessAddressBookPromptCount();
323 }
308 #endif // defined(OS_MACOSX) && !defined(OS_IOS) 324 #endif // defined(OS_MACOSX) && !defined(OS_IOS)
309 325
310 bool AutofillManager::OnFormSubmitted(const FormData& form, 326 bool AutofillManager::OnFormSubmitted(const FormData& form,
311 const TimeTicks& timestamp) { 327 const TimeTicks& timestamp) {
312 if (!IsValidFormData(form)) 328 if (!IsValidFormData(form))
313 return false; 329 return false;
314 330
315 // Let Autocomplete know as well. 331 // Let Autocomplete know as well.
316 autocomplete_history_manager_->OnFormSubmitted(form); 332 autocomplete_history_manager_->OnFormSubmitted(form);
317 333
(...skipping 905 matching lines...) Expand 10 before | Expand all | Expand 10 after
1223 return false; 1239 return false;
1224 1240
1225 // Disregard forms that we wouldn't ever autofill in the first place. 1241 // Disregard forms that we wouldn't ever autofill in the first place.
1226 if (!form.ShouldBeParsed()) 1242 if (!form.ShouldBeParsed())
1227 return false; 1243 return false;
1228 1244
1229 return true; 1245 return true;
1230 } 1246 }
1231 1247
1232 } // namespace autofill 1248 } // namespace autofill
OLDNEW
« no previous file with comments | « components/autofill/core/browser/autofill_manager.h ('k') | components/autofill/core/browser/personal_data_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698