mac: Only show the access Address Book prompt a fixed number of times.

components/autofill/core/browser/personal_data_manager_mac.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/personal_data_manager.h"
 
 #include <math.h>
 
 #import <AddressBook/AddressBook.h>
 
@@ skipping 13 matching lines @@
 #include "components/autofill/core/browser/form_structure.h"
 #include "components/autofill/core/browser/phone_number.h"
 #include "components/autofill/core/common/autofill_pref_names.h"
 #include "components/autofill/core/common/form_data.h"
 #include "grit/components_strings.h"
 #include "ui/base/l10n/l10n_util_mac.h"
 
 namespace autofill {
 namespace {
 
+// The maximum number of instances when the access Address Book prompt should
+// be shown.
+int kMaxTimesToShowMacAddressBook = 5;
+
 // There is an uncommon sequence of events that causes the Address Book
 // permissions dialog to appear more than once for a given install of Chrome.
 //  1. Chrome has previously presented the Address Book permissions dialog.
 //  2. Chrome is launched.
 //  3. Chrome performs an auto-update, and changes its binary.
 //  4. Chrome attempts to access the Address Book for the first time since (2).
 // This sequence of events is rare because Chrome attempts to acess the Address
 // Book when the user focuses most form fields, so (4) generally occurs before
 // (3). For more details, see http://crbug.com/381763.
 //
@@ skipping 320 matching lines @@
 bool PersonalDataManager::ShouldShowAccessAddressBookSuggestion(
     AutofillType type) {
   // Don't show the access Address Book prompt if the user has built up any
   // Autofill state.
   if (!web_profiles_.empty())
     return false;
 
   if (!enabled_pref_->GetValue())
     return false;
 
   if (HasPromptedForAccessToAddressBook(pref_service_))

[Evan Stade, 2014/09/18 22:06:09]

this is pretty confusing function naming. HasPromptedForAccessToAddressBook
might be false, even though AccessAddressBookPromptCount is non zero? There must
be some better names to help distinguish between the suggestion item and the osx
dialog box.

[erikchen, 2014/09/18 22:49:50]

I went with the name of the preference, which uses the key word "query", and
avoids the word "prompt".

     return false;
 
+  if (AccessAddressBookPromptCount() >= kMaxTimesToShowMacAddressBook)
+    return false;
+
   switch (type.group()) {
     case ADDRESS_BILLING:
     case ADDRESS_HOME:
     case EMAIL:
     case NAME:
     case NAME_BILLING:
     case PHONE_BILLING:
     case PHONE_HOME:
       return true;
     case NO_GROUP:
     case COMPANY:
     case CREDIT_CARD:
     case PASSWORD_FIELD:
     case TRANSACTION:
       return false;
   }
 
   return false;
 }
 
+void PersonalDataManager::ShowedAccessAddressBookPrompt() {
+  pref_service_->SetInteger(prefs::kAutofillMacAddressBookShowedCount,
+                            AccessAddressBookPromptCount() + 1);
+}
+
+int PersonalDataManager::AccessAddressBookPromptCount() {
+  return pref_service_->GetInteger(prefs::kAutofillMacAddressBookShowedCount);
+}
+
 void PersonalDataManager::BinaryChanging() {
   g_binary_changed = true;
 }
 
 }  // namespace autofill