Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 578353002: Third attempt to land change to remove NativeViewportService and (Closed)

Created:
6 years, 3 months ago by DaveMoore
Modified:
6 years, 3 months ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Third attempt to land change to remove NativeViewportService and ViewManager from mojo_shell. Original cl was https://codereview.chromium.org/477923004/ BUG= TBR=ben@chromium.org Committed: https://crrev.com/9b5afe9fda3e59c856cbfc43367c2719df676af0 Cr-Commit-Position: refs/heads/master@{#295537}

Patch Set 1 #

Patch Set 2 : Add view_manager and native_viewport_service as DEPS in gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -169 lines) Patch
M mojo/aura/aura_init.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo.gyp View 10 chunks +12 lines, -35 lines 0 comments Download
M mojo/mojo_examples.gypi View 5 chunks +1 line, -5 lines 0 comments Download
M mojo/mojo_services.gypi View 1 11 chunks +36 lines, -13 lines 0 comments Download
M mojo/services/BUILD.gn View 2 chunks +4 lines, -1 line 0 comments Download
M mojo/services/html_viewer/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/services/html_viewer/html_viewer.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M mojo/services/native_viewport/BUILD.gn View 3 chunks +16 lines, -10 lines 0 comments Download
M mojo/services/native_viewport/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A mojo/services/native_viewport/main.cc View 1 chunk +102 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/BUILD.gn View 2 chunks +4 lines, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/BUILD.gn View 1 chunk +7 lines, -8 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_test_suite.cc View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/services/public/interfaces/native_viewport/native_viewport.mojom View 1 chunk +7 lines, -0 lines 0 comments Download
M mojo/services/view_manager/BUILD.gn View 3 chunks +11 lines, -5 lines 0 comments Download
M mojo/services/view_manager/ids.h View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/services/view_manager/view_manager_unittest.cc View 3 chunks +11 lines, -7 lines 0 comments Download
M mojo/services/window_manager/BUILD.gn View 2 chunks +1 line, -6 lines 0 comments Download
M mojo/shell/BUILD.gn View 5 chunks +5 lines, -29 lines 0 comments Download
M mojo/shell/context.cc View 4 chunks +5 lines, -25 lines 0 comments Download
M mojo/shell/desktop/mojo_main.cc View 3 chunks +14 lines, -16 lines 0 comments Download
M mojo/shell/in_process_dynamic_service_runner.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/578353002/20001
6 years, 3 months ago (2014-09-18 19:04:23 UTC) #2
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 72bc11b5cd84391fd81052d95ce8d8bcc0099c60
6 years, 3 months ago (2014-09-18 20:03:11 UTC) #3
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/9b5afe9fda3e59c856cbfc43367c2719df676af0 Cr-Commit-Position: refs/heads/master@{#295537}
6 years, 3 months ago (2014-09-18 20:03:49 UTC) #4
DaveMoore
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/583573007/ by davemoore@chromium.org. ...
6 years, 3 months ago (2014-09-18 21:46:19 UTC) #5
Dan Beam
6 years, 3 months ago (2014-09-18 21:46:21 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/577403002/ by dbeam@chromium.org.

The reason for reverting is: all these tests are timing out on Win7 Tests
(dbg)(4):mojo_view_manager_unittests -
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(dbg)(4)/bu...

ViewManagerTest.CantAccessChildrenOfEmbeddedView
ViewManagerTest.SecondEmbedRoot_Service
ViewManagerTest.EmbedWithSameViewId2
ViewManagerTest.EmbedWithSameViewId
ViewManagerTest.ViewsRemovedWhenEmbedding
ViewManagerTest.CantGetViewTreeOfOtherRoots
ViewManagerTest.SetViewVisibilityNotifications
ViewManagerTest.CreateView
ViewManagerTest.ViewHierarchyChangedAddingKnownToUnknown
ViewManagerTest.GetViewTree
ViewManagerTest.ViewHierarchyChangedViews
ViewManagerTest.ReuseDeletedViewId
ViewManagerTest.AddViewWithNoChange
ViewManagerTest.ReorderView
ViewManagerTest.SetViewVisibility
ViewManagerTest.CantModifyChildrenOfEmbeddedView
ViewManagerTest.OnViewInput
ViewManagerTest.CantMoveViewsFromOtherRoot
ViewManagerTest.TwoClientsGetDifferentConnectionIds
ViewManagerTest.SetViewBounds.

Powered by Google App Engine
This is Rietveld 408576698