Chromium Code Reviews| Index: chrome/browser/about_flags.cc |
| diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc |
| index a1d3a56a8e87c6d6eb82b2bb92ccaec66f6be38c..55d36a8badbd7596998ab6e2646113255cda9b50 100644 |
| --- a/chrome/browser/about_flags.cc |
| +++ b/chrome/browser/about_flags.cc |
| @@ -2017,7 +2017,8 @@ void GetSanitizedEnabledFlags( |
| *result = flags_storage->GetFlags(); |
| } |
| -bool SkipConditionalExperiment(const Experiment& experiment) { |
| +bool SkipConditionalExperiment(const Experiment& experiment, |
| + FlagsStorage* flags_storage) { |
| if (experiment.internal_name == |
| std::string("enhanced-bookmarks-experiment")) { |
| #if defined(OS_ANDROID) |
| @@ -2030,7 +2031,7 @@ bool SkipConditionalExperiment(const Experiment& experiment) { |
| if (command_line->HasSwitch(switches::kEnhancedBookmarksExperiment)) |
| return false; |
| - return !IsEnhancedBookmarksExperimentEnabled(); |
| + return !IsEnhancedBookmarksExperimentEnabled(flags_storage); |
| #endif |
| } |
| @@ -2172,7 +2173,7 @@ void GetFlagsExperimentsData(FlagsStorage* flags_storage, |
| for (size_t i = 0; i < num_experiments; ++i) { |
| const Experiment& experiment = experiments[i]; |
| - if (SkipConditionalExperiment(experiment)) |
| + if (SkipConditionalExperiment(experiment, flags_storage)) |
| continue; |
| base::DictionaryValue* data = new base::DictionaryValue(); |
| @@ -2369,6 +2370,12 @@ void FlagsState::ConvertFlagsToSwitches(FlagsStorage* flags_storage, |
| continue; |
| } |
| +#if defined(OS_CHROMEOS) |
| + if (experiment_name == "manual-enhanced-bookmarks") { |
|
sky
2014/09/24 17:22:09
nit: no {}
And add a description as to why this is
yefimt
2014/09/24 18:46:12
Done.
|
| + continue; |
| + } |
| +#endif |
| + |
| const std::pair<std::string, std::string>& |
| switch_and_value_pair = name_to_switch_it->second; |