chrome/browser/bookmarks/DEPS - Issue 578333003: Workaround to remove command line flag on ChromeOS.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/bookmarks/DEPS

Issue 578333003: Workaround to remove command line flag on ChromeOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/about_flags.cc ('K') | « chrome/browser/about_flags.cc ('k') | chrome/browser/bookmarks/enhanced_bookmarks_features.h » ('j') | chrome/browser/bookmarks/enhanced_bookmarks_features.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 # Bookmarks is being made into a component (it will end up at	2 # Bookmarks is being made into a component (it will end up at

3 # //components/bookmarks and not depend on //chrome), so we have these basic	3 # //components/bookmarks and not depend on //chrome), so we have these basic

4 # rules followed by temporary exceptions. Please don't add to the list of	4 # rules followed by temporary exceptions. Please don't add to the list of

5 # exceptions!	5 # exceptions!

6 "-chrome/browser",	6 "-chrome/browser",

7 "+chrome/browser/bookmarks",	7 "+chrome/browser/bookmarks",

8 "+chrome/browser/browser_process.h",	8 "+chrome/browser/browser_process.h",

9 "+chrome/browser/favicon",	9 "+chrome/browser/favicon",

10 "+chrome/browser/chrome_notification_types.h",	10 "+chrome/browser/chrome_notification_types.h",

(...skipping 16 matching lines...) Expand all Loading...
27 # Do not add to the list of temporarily-allowed dependencies above,	27 # Do not add to the list of temporarily-allowed dependencies above,

28 # and please do not introduce more #includes of these files.	28 # and please do not introduce more #includes of these files.

29 ]	29 ]

30	30

31 specific_include_rules = {	31 specific_include_rules = {

32 # For unit tests, it's fine to include utility process code.	32 # For unit tests, it's fine to include utility process code.

33 '.*test\.cc': [	33 '.*test\.cc': [

34 "+chrome/test/base/testing_profile.h",	34 "+chrome/test/base/testing_profile.h",

35 "+chrome/utility/importer/bookmark_html_reader.h",	35 "+chrome/utility/importer/bookmark_html_reader.h",

36 ],	36 ],

	37 # Allow to include flags_storage into enhanced_bookmarks_features.cc.
	sky 2014/09/24 17:22:09 This just documents what you're doing, and isn't u This just documents what you're doing, and isn't useful. Document why. yefimt 2014/09/24 18:46:12 Done. Show quoted text On 2014/09/24 17:22:09, sky wrote: > This just documents what you're doing, and isn't useful. Document why. Done.
	38 'enhanced_bookmarks_features\.cc': [

	39 "+chrome/browser/flags_storage.h",

	40 ],

37 }	41 }

OLD	NEW