Always check if View::GetWidget() is NULL.

Always check if View::GetWidget() is NULL.

BUG=309121
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233429

[sky, 2013-11-04 21:06:35]

https://codereview.chromium.org/57833004/diff/1/ui/views/accessibility/native...
File ui/views/accessibility/native_view_accessibility_win.cc (right):

https://codereview.chromium.org/57833004/diff/1/ui/views/accessibility/native...
ui/views/accessibility/native_view_accessibility_win.cc:257: return E_FAIL;
Should the check for widget be moved here?

[dmazzoni, 2013-11-04 21:12:16]

https://codereview.chromium.org/57833004/diff/1/ui/views/accessibility/native...
File ui/views/accessibility/native_view_accessibility_win.cc (right):

https://codereview.chromium.org/57833004/diff/1/ui/views/accessibility/native...
ui/views/accessibility/native_view_accessibility_win.cc:257: return E_FAIL;
On 2013/11/04 21:06:36, sky wrote:
> Should the check for widget be moved here?

That seems reasonable. If there's no widget, it can't possibly be returning any
useful information.

I made a similar change throughout.

[sky, 2013-11-04 21:26:08]

LGTM

https://codereview.chromium.org/57833004/diff/70001/ui/views/accessibility/na...
File ui/views/accessibility/native_view_accessibility_win.cc (right):

https://codereview.chromium.org/57833004/diff/70001/ui/views/accessibility/na...
ui/views/accessibility/native_view_accessibility_win.cc:536: if (!view_ ||
!view_->GetWidget())
nit: you've got !view_ on 533 too.

[dmazzoni, 2013-11-04 21:31:19]

https://codereview.chromium.org/57833004/diff/70001/ui/views/accessibility/na...
File ui/views/accessibility/native_view_accessibility_win.cc (right):

https://codereview.chromium.org/57833004/diff/70001/ui/views/accessibility/na...
ui/views/accessibility/native_view_accessibility_win.cc:536: if (!view_ ||
!view_->GetWidget())
On 2013/11/04 21:26:09, sky wrote:
> nit: you've got !view_ on 533 too.

Done.

[commit-bot: I haz the power, 2013-11-04 21:37:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/57833004/120001

[commit-bot: I haz the power, 2013-11-05 01:13:54]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-11-05 18:09:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/57833004/120001

[commit-bot: I haz the power, 2013-11-05 22:39:54]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-11-06 23:32:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/57833004/120001

[commit-bot: I haz the power, 2013-11-07 00:19:33]

Change committed as 233429