Issue 578233002: Don't inline polymorphic cases if not all cases can be handled inline.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 578233002: Don't inline polymorphic cases if not all cases can be handled inline. (Closed)

Created:
6 years, 3 months ago by Toon Verwaest

Modified:
6 years, 3 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Don't inline polymorphic cases if not all cases can be handled inline. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24029

Patch Set 1 #

Total comments: 1

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -4 lines)			Patch
	M	src/hydrogen.cc	View		4 chunks	+16 lines, -4 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jakob Kummerow

LGTM with nit. https://codereview.chromium.org/578233002/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/578233002/diff/1/src/hydrogen.cc#newcode6298 src/hydrogen.cc:6298: nit: unnecessary empty line

6 years, 3 months ago (2014-09-18 09:48:45 UTC) #3

Toon Verwaest

6 years, 3 months ago (2014-09-18 10:57:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 24029 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages