Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 57823002: Adapt hidpi spelling tests to use async path for spellcheck (Closed)

Created:
7 years, 1 month ago by grzegorz
Modified:
7 years, 1 month ago
CC:
blink-reviews, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Adapt hidpi spelling tests to use async path for spellcheck Apply changes from https://codereview.chromium.org/49613006/ to inline-spelling-markers-hidpi.html and editing/spelling/inline-spelling-markers-hidpi-composited.html. BUG=295722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161439

Patch Set 1 #

Total comments: 4

Patch Set 2 : Use resources/js-test.js and remove js-test-post.js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -90 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/editing/spelling/inline-spelling-markers-hidpi.html View 1 2 chunks +72 lines, -41 lines 0 comments Download
M LayoutTests/editing/spelling/inline-spelling-markers-hidpi-composited.html View 1 2 chunks +72 lines, -41 lines 0 comments Download
M LayoutTests/editing/spelling/inline-spelling-markers-hidpi-composited-expected.txt View 1 chunk +33 lines, -4 lines 0 comments Download
M LayoutTests/editing/spelling/inline-spelling-markers-hidpi-expected.txt View 1 chunk +33 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
grzegorz
This CL needs https://codereview.chromium.org/49613006/ to be landed first - due to modifications in MockGrammarCheck.cpp.
7 years, 1 month ago (2013-11-04 12:47:42 UTC) #1
grzegorz
7 years, 1 month ago (2013-11-04 12:48:23 UTC) #2
tony
https://codereview.chromium.org/57823002/diff/1/LayoutTests/editing/spelling/inline-spelling-markers-hidpi-composited.html File LayoutTests/editing/spelling/inline-spelling-markers-hidpi-composited.html (right): https://codereview.chromium.org/57823002/diff/1/LayoutTests/editing/spelling/inline-spelling-markers-hidpi-composited.html#newcode112 LayoutTests/editing/spelling/inline-spelling-markers-hidpi-composited.html:112: <script src="../../fast/js/resources/js-test-post.js"></script> This file doesn't exist anymore. https://codereview.chromium.org/57823002/diff/1/LayoutTests/editing/spelling/inline-spelling-markers-hidpi.html File ...
7 years, 1 month ago (2013-11-04 17:59:09 UTC) #3
grzegorz
https://codereview.chromium.org/57823002/diff/1/LayoutTests/editing/spelling/inline-spelling-markers-hidpi-composited.html File LayoutTests/editing/spelling/inline-spelling-markers-hidpi-composited.html (right): https://codereview.chromium.org/57823002/diff/1/LayoutTests/editing/spelling/inline-spelling-markers-hidpi-composited.html#newcode112 LayoutTests/editing/spelling/inline-spelling-markers-hidpi-composited.html:112: <script src="../../fast/js/resources/js-test-post.js"></script> On 2013/11/04 17:59:09, tony wrote: > This ...
7 years, 1 month ago (2013-11-06 07:47:23 UTC) #4
Hajime Morrita
rubberstamping lgtm and cq.
7 years, 1 month ago (2013-11-06 07:55:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/g.czajkowski@samsung.com/57823002/80001
7 years, 1 month ago (2013-11-06 07:56:02 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-11-06 09:32:37 UTC) #7
Message was sent while issue was closed.
Change committed as 161439

Powered by Google App Engine
This is Rietveld 408576698