Experimental app list: Enforce a 24-pixel padding on the top and sides.

Experimental app list: Enforce a 24-pixel padding on the top and sides.

Applies to the horizontal divider line under the folder heading, and
above the contents switcher view, and the folder back button. Also set
the contents switcher background colour to the main background colour
(it doesn't make sense to have a different colour if the divider line
doesn't reach all the way to the edge).

BUG=411775
Committed: https://crrev.com/4bf6b51483cc45923628653eaf750405a748a780
Cr-Commit-Position: refs/heads/master@{#295710}

[Matt Giuca, 2014-09-18 08:52:09]

mgiuca@chromium.org changed reviewers:
+ calamity@chromium.org

[Matt Giuca, 2014-09-18 08:52:10]

Screenshots at https://code.google.com/p/chromium/issues/detail?id=411775#c13

Hmm, the folder name moved horizontally. I'll have to investigate whether the
old or new one was better. Otherwise ready.

[calamity, 2014-09-19 05:10:56]

lgtm.

https://codereview.chromium.org/578223002/diff/1/ui/app_list/views/app_list_b...
File ui/app_list/views/app_list_background.cc (right):

https://codereview.chromium.org/578223002/diff/1/ui/app_list/views/app_list_b...
ui/app_list/views/app_list_background.cc:92: kExperimentalWindowPadding * 2);
Use Rect::Inset()

https://codereview.chromium.org/578223002/diff/1/ui/app_list/views/app_list_b...
ui/app_list/views/app_list_background.cc:103:
canvas->DrawRect(contents_switcher_rect, paint);
96-103 is unnecessary now.

https://codereview.chromium.org/578223002/diff/1/ui/app_list/views/folder_hea...
File ui/app_list/views/folder_header_view.cc (right):

https://codereview.chromium.org/578223002/diff/1/ui/app_list/views/folder_hea...
ui/app_list/views/folder_header_view.cc:206: rect.set_y(rect.y() + rect.height()
- kBottomSeparatorHeight);
Use rect.bottom().

https://codereview.chromium.org/578223002/diff/1/ui/app_list/views/folder_hea...
ui/app_list/views/folder_header_view.cc:207: rect.set_width(rect.width() -
horizontal_padding * 2);
Use Rect::Inset().

[Matt Giuca, 2014-09-19 09:56:05]

PTAL at new changes to AppListMainView.

https://codereview.chromium.org/578223002/diff/1/ui/app_list/views/app_list_b...
File ui/app_list/views/app_list_background.cc (right):

https://codereview.chromium.org/578223002/diff/1/ui/app_list/views/app_list_b...
ui/app_list/views/app_list_background.cc:92: kExperimentalWindowPadding * 2);
On 2014/09/19 05:10:56, calamity wrote:
> Use Rect::Inset()

Done. (Also this was buggy before because it assumes x was 0 beforehand --- it's
actually 5.)

https://codereview.chromium.org/578223002/diff/1/ui/app_list/views/app_list_b...
ui/app_list/views/app_list_background.cc:103:
canvas->DrawRect(contents_switcher_rect, paint);
On 2014/09/19 05:10:56, calamity wrote:
> 96-103 is unnecessary now.

Done.

https://codereview.chromium.org/578223002/diff/1/ui/app_list/views/folder_hea...
File ui/app_list/views/folder_header_view.cc (right):

https://codereview.chromium.org/578223002/diff/1/ui/app_list/views/folder_hea...
ui/app_list/views/folder_header_view.cc:206: rect.set_y(rect.y() + rect.height()
- kBottomSeparatorHeight);
On 2014/09/19 05:10:56, calamity wrote:
> Use rect.bottom().

Done.

https://codereview.chromium.org/578223002/diff/1/ui/app_list/views/folder_hea...
ui/app_list/views/folder_header_view.cc:207: rect.set_width(rect.width() -
horizontal_padding * 2);
On 2014/09/19 05:10:56, calamity wrote:
> Use Rect::Inset().

Done.

[calamity, 2014-09-19 10:02:27]

slgtm

[Matt Giuca, 2014-09-19 14:13:27]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-09-19 14:14:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/578223002/40001

[commit-bot: I haz the power, 2014-09-19 15:09:55]

Committed patchset #3 (id:40001) as 3c833fb7bfd7ece9b7662c899c03bb0e4770eeb6

[commit-bot: I haz the power, 2014-09-19 15:10:32]

Patchset 3 (id:??) landed as
https://crrev.com/4bf6b51483cc45923628653eaf750405a748a780
Cr-Commit-Position: refs/heads/master@{#295710}