Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 578203003: Complete partial documentation of root .gn's secondary_source. (Closed)

Created:
6 years, 3 months ago by scheib
Modified:
6 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Project:
chromium
Visibility:
Public.

Description

Complete partial documentation of root .gn's secondary_source. Committed: https://crrev.com/ec4b3a4e4112fcc420afed5b749eb714187a50b2 Cr-Commit-Position: refs/heads/master@{#295565}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M .gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
scheib
6 years, 3 months ago (2014-09-18 16:57:52 UTC) #2
brettw
lgtm
6 years, 3 months ago (2014-09-18 20:22:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/578203003/1
6 years, 3 months ago (2014-09-18 20:36:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 23e9825048a9b2da995ad7fb65a67e4f0e58b4dd
6 years, 3 months ago (2014-09-18 21:50:19 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 21:51:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec4b3a4e4112fcc420afed5b749eb714187a50b2
Cr-Commit-Position: refs/heads/master@{#295565}

Powered by Google App Engine
This is Rietveld 408576698