Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: src/sampler.h

Issue 578163002: Implemented GetSample. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Including win32-headers.h in v8.h for testing on trybots. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/sampler.h
diff --git a/src/sampler.h b/src/sampler.h
index c3dce4ed7c2fec7e353cb06d1641f63e82092a84..82d87711db2b5671bceac230315ca78b29771adb 100644
--- a/src/sampler.h
+++ b/src/sampler.h
@@ -5,6 +5,8 @@
#ifndef V8_SAMPLER_H_
#define V8_SAMPLER_H_
+#include "include/v8.h"
+
#include "src/base/atomicops.h"
#include "src/frames.h"
#include "src/globals.h"
@@ -21,13 +23,6 @@ class Isolate;
// (if used for profiling) the program counter and stack pointer for
// the thread that created it.
-struct RegisterState {
yurys 2014/09/19 08:08:12 I would expect this struct to be moved into v8.h a
- RegisterState() : pc(NULL), sp(NULL), fp(NULL) {}
- Address pc; // Instruction pointer.
- Address sp; // Stack pointer.
- Address fp; // Frame pointer.
-};
-
// TickSample captures the information collected for each sample.
struct TickSample {
TickSample()
@@ -37,7 +32,7 @@ struct TickSample {
frames_count(0),
has_external_callback(false),
top_frame_type(StackFrame::NONE) {}
- void Init(Isolate* isolate, const RegisterState& state);
+ void Init(Isolate* isolate, const v8::RegisterState& state);
StateTag state; // The state of the VM.
Address pc; // Instruction pointer.
union {
@@ -67,7 +62,7 @@ class Sampler {
int interval() const { return interval_; }
// Performs stack sampling.
- void SampleStack(const RegisterState& regs);
+ void SampleStack(const v8::RegisterState& regs);
// Start and stop sampler.
void Start();

Powered by Google App Engine
This is Rietveld 408576698