Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 57813008: Clicking a non-focusable element in an inactive frame should clear focus in the frame. (Closed)

Created:
7 years, 1 month ago by tkent
Modified:
7 years, 1 month ago
Reviewers:
hayato
CC:
blink-reviews
Visibility:
Public.

Description

Clicking a non-focusable element in an inactive frame should clear focus in the frame. Clicking a non-focusable element in an inactive frame did not remove focus from the focused element in the frame because - FocusController::setFocusedElement incorrectly returned earlier if there was no focused element in the currently focused frame, and - FocusController::setFocusedElement cleared focus in the currently focused frame if new focused element is 0, but did not clear the focus in the new focused frame. We shouldn't do early-return for a element==0 case. Also, we need to to call clearSelectionIfNeeded() later than same-element check to avoid test breakage. BUG=304145 TEST=automated. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161312

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -10 lines) Patch
A LayoutTests/fast/events/frame-click-clear-focus.html View 1 chunk +32 lines, -0 lines 0 comments Download
A LayoutTests/fast/events/frame-click-clear-focus-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
M Source/core/page/FocusController.cpp View 2 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tkent
Hayato-san, would you review this please?
7 years, 1 month ago (2013-11-05 03:48:15 UTC) #1
hayato
lgtm
7 years, 1 month ago (2013-11-05 06:50:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/57813008/60001
7 years, 1 month ago (2013-11-05 06:51:32 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 07:00:34 UTC) #4
Message was sent while issue was closed.
Change committed as 161312

Powered by Google App Engine
This is Rietveld 408576698