tools/telemetry/telemetry/core/platform/platform_backend.py - Issue 578123002: [telemetry] Read MSRs from a separate privileged process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/platform_backend.py

Issue 578123002: [telemetry] Read MSRs from a separate privileged process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add pre-Vista check and increase server launch timeout. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/platform/msr_server_win.py ('k') | tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/platform_backend.py

diff --git a/tools/telemetry/telemetry/core/platform/platform_backend.py b/tools/telemetry/telemetry/core/platform/platform_backend.py

index 0d6ae3465f9513cd73a2e39f2be521e3cba7397d..710b8e596d45cffa86725b5d2f5496ca53cf3600 100644

--- a/tools/telemetry/telemetry/core/platform/platform_backend.py

+++ b/tools/telemetry/telemetry/core/platform/platform_backend.py

@@ -207,3 +207,11 @@ class PlatformBackend(object):

def StopMonitoringPower(self):

raise NotImplementedError()

+ def ReadMsr(self, msr_number):

+ """Read a CPU model-specific register (MSR).

+ Which MSRs are available depends on the CPU model.

+ On systems with multiple CPUs, this function may run on any CPU.

+ """

+ raise NotImplementedError()