tools/telemetry/telemetry/core/platform/platform_backend.py - Issue 578123002: [telemetry] Read MSRs from a separate privileged process.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/telemetry/telemetry/core/platform/platform_backend.py

Issue 578123002: [telemetry] Read MSRs from a separate privileged process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« tools/telemetry/telemetry/core/platform/msr_server_win.py ('K') | « tools/telemetry/telemetry/core/platform/msr_server_win.py ('k') | tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor.py » ('j') | tools/telemetry/telemetry/core/platform/win_platform_backend.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2013 The Chromium Authors. All rights reserved.	1 # Copyright 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import weakref	5 import weakref

6	6

7 from telemetry.core.platform import profiling_controller_backend	7 from telemetry.core.platform import profiling_controller_backend

8 from telemetry.core.platform import tracing_controller_backend	8 from telemetry.core.platform import tracing_controller_backend

9	9

10	10

(...skipping 189 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
200 return False	200 return False

201	201

202 def CanMeasurePerApplicationPower(self):	202 def CanMeasurePerApplicationPower(self):

203 return False	203 return False

204	204

205 def StartMonitoringPower(self, browser):	205 def StartMonitoringPower(self, browser):

206 raise NotImplementedError()	206 raise NotImplementedError()

207	207

208 def StopMonitoringPower(self):	208 def StopMonitoringPower(self):

209 raise NotImplementedError()	209 raise NotImplementedError()

	210

	211 def ReadMsr(self, msr_number):
	tonyg 2014/09/18 00:21:46 I think we should add a comment that defines MSR. I think we should add a comment that defines MSR. dtu 2014/09/18 05:22:29 Done. Show quoted text On 2014/09/18 00:21:46, tonyg wrote: > I think we should add a comment that defines MSR. Done.
	212 raise NotImplementedError()

OLD	NEW