Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 578103002: Add a new SBThreatType for the harmful download interstitial (Closed)

Created:
6 years, 3 months ago by felt
Modified:
6 years, 3 months ago
Reviewers:
mattm
CC:
chromium-reviews, gab
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add a new SBThreatType for the harmful download interstitial BUG=397754 R=mattm@chromium.org Committed: https://crrev.com/0130f1575b2c398a959126587e29f2d9352e8fda Cr-Commit-Position: refs/heads/master@{#295852}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_util.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
felt
Hi Matt, PTAL. New enum needed to support the new interstitial type.
6 years, 3 months ago (2014-09-17 23:51:05 UTC) #1
mattm
lgtm
6 years, 3 months ago (2014-09-19 20:35:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/578103002/1
6 years, 3 months ago (2014-09-19 20:42:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/578103002/1
6 years, 3 months ago (2014-09-19 20:42:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/11472)
6 years, 3 months ago (2014-09-19 21:26:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/578103002/1
6 years, 3 months ago (2014-09-20 02:45:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/578103002/1
6 years, 3 months ago (2014-09-20 02:45:59 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as a921e43133cca6e8b397a1d1c663b907daaa2dde
6 years, 3 months ago (2014-09-20 02:49:40 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-20 02:50:17 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0130f1575b2c398a959126587e29f2d9352e8fda
Cr-Commit-Position: refs/heads/master@{#295852}

Powered by Google App Engine
This is Rietveld 408576698