Chromium Code Reviews
Help | Chromium Project | Sign in
(815)

Issue 5781004: Align builtins-{arch}.cc on ia32 and x64 platforms by moving functions and ed... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 4 months ago by William Hesse
Modified:
2 years, 11 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Align builtins-{arch}.cc on ia32 and x64 platforms by moving functions and editing.

Committed: http://code.google.com/p/v8/source/detail?r=5984

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+596 lines, -567 lines) Lint Patch
M src/ia32/builtins-ia32.cc View 1 chunk +0 lines, -1 line 0 comments 0 errors Download
M src/x64/builtins-x64.cc View 6 chunks +564 lines, -566 lines 3 comments 4 errors Download
M src/x64/macro-assembler-x64.h View 1 chunk +7 lines, -0 lines 0 comments 0 errors Download
M src/x64/macro-assembler-x64.cc View 1 chunk +25 lines, -0 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 2
William Hesse
Simple change, just reordering the functions within builtins-x64.cc, plus a tiny refactoring noted below. http://codereview.chromium.org/5781004/diff/1/src/x64/builtins-x64.cc ...
3 years, 4 months ago #1
Lasse Reichstein
3 years, 4 months ago #2
LGTM, assuming it's only reorderings where you say it is :)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6