Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 578033002: DM: --gpu and --cpu should only control top-level tasks. (Closed)

Created:
6 years, 3 months ago by mtklein_C
Modified:
6 years, 3 months ago
Reviewers:
jcgregorio, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

DM: --gpu and --cpu should only control top-level tasks. This fixes a bug where we run some Android bots with --nocpu, and the current behavior disables the (CPU-bound) WriteTasks the GPU bound GM runs spawn off. The WriteTasks don't run and we end up with "null" in our .json files. Tested locally: out/Release/dm --nocpu -w /tmp/out; ls /tmp/out dm.json gpu/ BUG=skia:2938 Committed: https://skia.googlesource.com/skia/+/53e0be6d2b76321c2012085a73f1e7b269406c78

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M dm/DMTask.cpp View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mtklein
6 years, 3 months ago (2014-09-17 19:15:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/578033002/1
6 years, 3 months ago (2014-09-17 19:17:47 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 3 months ago (2014-09-17 19:17:48 UTC) #5
jcgregorio
On 2014/09/17 19:17:48, I haz the power (commit-bot) wrote: > Note for Reviewers: > The ...
6 years, 3 months ago (2014-09-17 19:18:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/578033002/1
6 years, 3 months ago (2014-09-17 19:21:47 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 19:26:22 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 53e0be6d2b76321c2012085a73f1e7b269406c78

Powered by Google App Engine
This is Rietveld 408576698