Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: src/arm/codegen-arm.cc

Issue 578014: ARM: Removed unused StubReturn (Closed)
Patch Set: Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm/macro-assembler-arm.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 6068 matching lines...) Expand 10 before | Expand all | Expand 10 after
6079 __ stop("Unreachable"); 6079 __ stop("Unreachable");
6080 } 6080 }
6081 6081
6082 6082
6083 void StackCheckStub::Generate(MacroAssembler* masm) { 6083 void StackCheckStub::Generate(MacroAssembler* masm) {
6084 // Do tail-call to runtime routine. Runtime routines expect at least one 6084 // Do tail-call to runtime routine. Runtime routines expect at least one
6085 // argument, so give it a Smi. 6085 // argument, so give it a Smi.
6086 __ mov(r0, Operand(Smi::FromInt(0))); 6086 __ mov(r0, Operand(Smi::FromInt(0)));
6087 __ push(r0); 6087 __ push(r0);
6088 __ TailCallRuntime(ExternalReference(Runtime::kStackGuard), 1, 1); 6088 __ TailCallRuntime(ExternalReference(Runtime::kStackGuard), 1, 1);
6089
6090 __ StubReturn(1);
6091 } 6089 }
6092 6090
6093 6091
6094 void GenericUnaryOpStub::Generate(MacroAssembler* masm) { 6092 void GenericUnaryOpStub::Generate(MacroAssembler* masm) {
6095 Label slow, done; 6093 Label slow, done;
6096 6094
6097 if (op_ == Token::SUB) { 6095 if (op_ == Token::SUB) {
6098 // Check whether the value is a smi. 6096 // Check whether the value is a smi.
6099 Label try_float; 6097 Label try_float;
6100 __ tst(r0, Operand(kSmiTagMask)); 6098 __ tst(r0, Operand(kSmiTagMask));
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
6160 // have to set up a frame. 6158 // have to set up a frame.
6161 WriteInt32ToHeapNumberStub stub(r1, r0, r2); 6159 WriteInt32ToHeapNumberStub stub(r1, r0, r2);
6162 __ push(lr); 6160 __ push(lr);
6163 __ Call(stub.GetCode(), RelocInfo::CODE_TARGET); 6161 __ Call(stub.GetCode(), RelocInfo::CODE_TARGET);
6164 __ pop(lr); 6162 __ pop(lr);
6165 } else { 6163 } else {
6166 UNIMPLEMENTED(); 6164 UNIMPLEMENTED();
6167 } 6165 }
6168 6166
6169 __ bind(&done); 6167 __ bind(&done);
6170 __ StubReturn(1); 6168 __ Ret();
6171 6169
6172 // Handle the slow case by jumping to the JavaScript builtin. 6170 // Handle the slow case by jumping to the JavaScript builtin.
6173 __ bind(&slow); 6171 __ bind(&slow);
6174 __ push(r0); 6172 __ push(r0);
6175 switch (op_) { 6173 switch (op_) {
6176 case Token::SUB: 6174 case Token::SUB:
6177 __ InvokeBuiltin(Builtins::UNARY_MINUS, JUMP_JS); 6175 __ InvokeBuiltin(Builtins::UNARY_MINUS, JUMP_JS);
6178 break; 6176 break;
6179 case Token::BIT_NOT: 6177 case Token::BIT_NOT:
6180 __ InvokeBuiltin(Builtins::BIT_NOT, JUMP_JS); 6178 __ InvokeBuiltin(Builtins::BIT_NOT, JUMP_JS);
(...skipping 1280 matching lines...) Expand 10 before | Expand all | Expand 10 after
7461 7459
7462 // Just jump to runtime to add the two strings. 7460 // Just jump to runtime to add the two strings.
7463 __ bind(&string_add_runtime); 7461 __ bind(&string_add_runtime);
7464 __ TailCallRuntime(ExternalReference(Runtime::kStringAdd), 2, 1); 7462 __ TailCallRuntime(ExternalReference(Runtime::kStringAdd), 2, 1);
7465 } 7463 }
7466 7464
7467 7465
7468 #undef __ 7466 #undef __
7469 7467
7470 } } // namespace v8::internal 7468 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/arm/macro-assembler-arm.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698