Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 578013003: fixes to linux build for webtry (Closed)

Created:
6 years, 3 months ago by humper
Modified:
6 years, 3 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

fixes to linux build for webtry BUG=skia: Committed: https://skia.googlesource.com/skia/+/95b7144adffc376e62c50c6d5010a3880dec61fa

Patch Set 1 #

Patch Set 2 : Remove Debugging Cruft #

Patch Set 3 : Make sure to flush the output stream before we exit #

Patch Set 4 : Fix linux run; don't try to mix SK_DEBUG with a release build! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -13 lines) Patch
M experimental/webtry/templates/template.gyp View 1 2 3 2 chunks +3 lines, -6 lines 0 comments Download
M experimental/webtry/webtry.go View 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
humper
Seems to work on my local linux box now, ptal
6 years, 3 months ago (2014-09-17 19:11:19 UTC) #2
humper
On 2014/09/17 19:11:19, humper wrote: > Seems to work on my local linux box now, ...
6 years, 3 months ago (2014-09-18 15:23:18 UTC) #3
jcgregorio
On 2014/09/18 15:23:18, humper wrote: > On 2014/09/17 19:11:19, humper wrote: > > Seems to ...
6 years, 3 months ago (2014-09-18 16:43:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/578013003/60001
6 years, 3 months ago (2014-09-18 17:50:55 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 17:58:37 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as 95b7144adffc376e62c50c6d5010a3880dec61fa

Powered by Google App Engine
This is Rietveld 408576698